From 2a6b7321741504856796a24f123dae891f55aca9 Mon Sep 17 00:00:00 2001 From: semimikoh Date: Wed, 15 Apr 2026 08:11:47 +0900 Subject: [PATCH 1/2] doc,src,test: fix dead inspector help URL --- doc/api/debugger.md | 10 +++++----- doc/api/inspector.md | 4 ++-- src/inspector_socket_server.cc | 3 +-- test/internet/test-inspector-help-page.js | 2 +- 4 files changed, 9 insertions(+), 10 deletions(-) diff --git a/doc/api/debugger.md b/doc/api/debugger.md index ce25c927d8ef81..798b918a41d84d 100644 --- a/doc/api/debugger.md +++ b/doc/api/debugger.md @@ -16,7 +16,7 @@ script to debug. ```console $ node inspect myscript.js < Debugger listening on ws://127.0.0.1:9229/621111f9-ffcb-4e82-b718-48a145fa5db8 -< For help, see: https://nodejs.org/en/docs/inspector +< For help, see: https://nodejs.org/api/inspector.html < connecting to 127.0.0.1:9229 ... ok < Debugger attached. @@ -45,7 +45,7 @@ setTimeout(() => { console.log('hello'); $ NODE_INSPECT_RESUME_ON_START=1 node inspect myscript.js < Debugger listening on ws://127.0.0.1:9229/f1ed133e-7876-495b-83ae-c32c6fc319c2 -< For help, see: https://nodejs.org/en/docs/inspector +< For help, see: https://nodejs.org/api/inspector.html < connecting to 127.0.0.1:9229 ... ok < Debugger attached. @@ -131,7 +131,7 @@ is not loaded yet: ```console $ node inspect main.js < Debugger listening on ws://127.0.0.1:9229/48a5b28a-550c-471b-b5e1-d13dd7165df9 -< For help, see: https://nodejs.org/en/docs/inspector +< For help, see: https://nodejs.org/api/inspector.html < connecting to 127.0.0.1:9229 ... ok < Debugger attached. @@ -158,7 +158,7 @@ given expression evaluates to `true`: ```console $ node inspect main.js < Debugger listening on ws://127.0.0.1:9229/ce24daa8-3816-44d4-b8ab-8273c8a66d35 -< For help, see: https://nodejs.org/en/docs/inspector +< For help, see: https://nodejs.org/api/inspector.html < connecting to 127.0.0.1:9229 ... ok < Debugger attached. @@ -253,7 +253,7 @@ or break on the first line for step-by-step debugging. ```console $ node --inspect index.js Debugger listening on ws://127.0.0.1:9229/dc9010dd-f8b8-4ac5-a510-c1a114ec7d29 -For help, see: https://nodejs.org/en/docs/inspector +For help, see: https://nodejs.org/api/inspector.html ``` (In the example above, the UUID dc9010dd-f8b8-4ac5-a510-c1a114ec7d29 diff --git a/doc/api/inspector.md b/doc/api/inspector.md index d5401e83789435..de1785e218ac11 100644 --- a/doc/api/inspector.md +++ b/doc/api/inspector.md @@ -465,12 +465,12 @@ Return the URL of the active inspector, or `undefined` if there is none. ```console $ node --inspect -p 'inspector.url()' Debugger listening on ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34 -For help, see: https://nodejs.org/en/docs/inspector +For help, see: https://nodejs.org/api/inspector.html ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34 $ node --inspect=localhost:3000 -p 'inspector.url()' Debugger listening on ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a -For help, see: https://nodejs.org/en/docs/inspector +For help, see: https://nodejs.org/api/inspector.html ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a $ node -p 'inspector.url()' diff --git a/src/inspector_socket_server.cc b/src/inspector_socket_server.cc index 4df85fe8461bae..67a54db0aea3f3 100644 --- a/src/inspector_socket_server.cc +++ b/src/inspector_socket_server.cc @@ -247,8 +247,7 @@ void PrintDebuggerReadyMessage( FormatWsAddress(host, server_socket->port(), id, true).c_str()); } } - fprintf(out, "For help, see: %s\n", - "https://nodejs.org/en/docs/inspector"); + fprintf(out, "For help, see: %s\n", "https://nodejs.org/api/inspector.html"); fflush(out); } diff --git a/test/internet/test-inspector-help-page.js b/test/internet/test-inspector-help-page.js index ae06242405d5fc..9569aa1491aea7 100644 --- a/test/internet/test-inspector-help-page.js +++ b/test/internet/test-inspector-help-page.js @@ -28,7 +28,7 @@ function check(url, cb) { }); res.on('end', common.mustCall(() => { - assert.match(result, />Debugging Node\.jsInspector \| Node\.js/); cb(); })); })).on('error', common.mustNotCall); From 403ae9c0ef168ff55ef8289c881d4bfa4c757876 Mon Sep 17 00:00:00 2001 From: semimikoh Date: Thu, 16 Apr 2026 00:21:27 +0900 Subject: [PATCH 2/2] doc,src,test: use moved inspector help page --- doc/api/debugger.md | 10 +++++----- doc/api/inspector.md | 4 ++-- src/inspector_socket_server.cc | 3 ++- test/internet/test-inspector-help-page.js | 2 +- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/doc/api/debugger.md b/doc/api/debugger.md index 798b918a41d84d..cafbd4215f3599 100644 --- a/doc/api/debugger.md +++ b/doc/api/debugger.md @@ -16,7 +16,7 @@ script to debug. ```console $ node inspect myscript.js < Debugger listening on ws://127.0.0.1:9229/621111f9-ffcb-4e82-b718-48a145fa5db8 -< For help, see: https://nodejs.org/api/inspector.html +< For help, see: https://nodejs.org/learn/getting-started/debugging < connecting to 127.0.0.1:9229 ... ok < Debugger attached. @@ -45,7 +45,7 @@ setTimeout(() => { console.log('hello'); $ NODE_INSPECT_RESUME_ON_START=1 node inspect myscript.js < Debugger listening on ws://127.0.0.1:9229/f1ed133e-7876-495b-83ae-c32c6fc319c2 -< For help, see: https://nodejs.org/api/inspector.html +< For help, see: https://nodejs.org/learn/getting-started/debugging < connecting to 127.0.0.1:9229 ... ok < Debugger attached. @@ -131,7 +131,7 @@ is not loaded yet: ```console $ node inspect main.js < Debugger listening on ws://127.0.0.1:9229/48a5b28a-550c-471b-b5e1-d13dd7165df9 -< For help, see: https://nodejs.org/api/inspector.html +< For help, see: https://nodejs.org/learn/getting-started/debugging < connecting to 127.0.0.1:9229 ... ok < Debugger attached. @@ -158,7 +158,7 @@ given expression evaluates to `true`: ```console $ node inspect main.js < Debugger listening on ws://127.0.0.1:9229/ce24daa8-3816-44d4-b8ab-8273c8a66d35 -< For help, see: https://nodejs.org/api/inspector.html +< For help, see: https://nodejs.org/learn/getting-started/debugging < connecting to 127.0.0.1:9229 ... ok < Debugger attached. @@ -253,7 +253,7 @@ or break on the first line for step-by-step debugging. ```console $ node --inspect index.js Debugger listening on ws://127.0.0.1:9229/dc9010dd-f8b8-4ac5-a510-c1a114ec7d29 -For help, see: https://nodejs.org/api/inspector.html +For help, see: https://nodejs.org/learn/getting-started/debugging ``` (In the example above, the UUID dc9010dd-f8b8-4ac5-a510-c1a114ec7d29 diff --git a/doc/api/inspector.md b/doc/api/inspector.md index de1785e218ac11..4cdbeb62d0e71a 100644 --- a/doc/api/inspector.md +++ b/doc/api/inspector.md @@ -465,12 +465,12 @@ Return the URL of the active inspector, or `undefined` if there is none. ```console $ node --inspect -p 'inspector.url()' Debugger listening on ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34 -For help, see: https://nodejs.org/api/inspector.html +For help, see: https://nodejs.org/learn/getting-started/debugging ws://127.0.0.1:9229/166e272e-7a30-4d09-97ce-f1c012b43c34 $ node --inspect=localhost:3000 -p 'inspector.url()' Debugger listening on ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a -For help, see: https://nodejs.org/api/inspector.html +For help, see: https://nodejs.org/learn/getting-started/debugging ws://localhost:3000/51cf8d0e-3c36-4c59-8efd-54519839e56a $ node -p 'inspector.url()' diff --git a/src/inspector_socket_server.cc b/src/inspector_socket_server.cc index 67a54db0aea3f3..56264bb6777c56 100644 --- a/src/inspector_socket_server.cc +++ b/src/inspector_socket_server.cc @@ -247,7 +247,8 @@ void PrintDebuggerReadyMessage( FormatWsAddress(host, server_socket->port(), id, true).c_str()); } } - fprintf(out, "For help, see: %s\n", "https://nodejs.org/api/inspector.html"); + fprintf(out, "For help, see: %s\n", + "https://nodejs.org/learn/getting-started/debugging"); fflush(out); } diff --git a/test/internet/test-inspector-help-page.js b/test/internet/test-inspector-help-page.js index 9569aa1491aea7..ae06242405d5fc 100644 --- a/test/internet/test-inspector-help-page.js +++ b/test/internet/test-inspector-help-page.js @@ -28,7 +28,7 @@ function check(url, cb) { }); res.on('end', common.mustCall(() => { - assert.match(result, /Inspector \| Node\.js/); + assert.match(result, />Debugging Node\.js</); cb(); })); })).on('error', common.mustNotCall);