Forms does not delete excess rows when exporting to files

[LAfricain]

If I make a correction—for example, deleting a duplicate in Forms—and then re-export the spreadsheet, the result in the spreadsheet is the same as it was before the correction.

Nextcloud (please complete the following information):

• Forms-Version: 5.2.9

Desktop (please complete the following information):

• OS: Ubuntu 24.04
• Browser Brave

[Chartman123]

@LAfricain please update to the latest version of Forms and see if the error persists.

[LAfricain]

The last is 5.2.9.

[Chartman123]

No, the latest is 5.3.2. 5.2.9 is only the latest one if you're still on an unsupported version of Nextcloud (<32). So please update your Nextcloud and Forms first :)

[LAfricain]

I have no admin right on my nextcloud instance. I have probably to wait the new release.

[Chartman123]

In the meantime I tried to reproduce it on my dev instance and can confirm the bug. So we'll investigate it further 👍🏻 Did you just use the "save copy to files" button or did you link a spreadsheet? I only tested it with the save copy button.

[Chartman123]

I think I found the problem here:

forms/lib/Service/SubmissionService.php

Line 394 in ce66591

private function exportData(array $header, array $data, string $fileFormat, ?File $file = null): string {

We take an existing file if available and overwrite it row by row. So if you delete some responses, you have fewer rows than before and so the rows with the highest numbers will stay the way they were before deletion. So we need to count the number of existing rows and take the number of responses and delete all rows in the file that are greater than the number of responses until the number of rows in the file is reached. Perhaps there's also some function in PhpSpreadsheet that allows to delete all rows after a specified row number.