From bf5966eebfd7dd3f9dfd4b11a133c30b0c855447 Mon Sep 17 00:00:00 2001 From: Ryan VanderMeulen Date: Wed, 23 Sep 2026 09:04:37 -0400 Subject: [PATCH] Give the SyncedTabsAdapter.getItemViewType() when subject a non-null type. Kotlin 2.5 warns that the platform-typed getItem() result is unhandled when null, which -Werror turns into a build failure. --- .../reference/browser/tabs/synced/SyncedTabsAdapter.kt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/reference/browser/tabs/synced/SyncedTabsAdapter.kt b/app/src/main/java/org/mozilla/reference/browser/tabs/synced/SyncedTabsAdapter.kt index 2bc1df99c..393f69b08 100644 --- a/app/src/main/java/org/mozilla/reference/browser/tabs/synced/SyncedTabsAdapter.kt +++ b/app/src/main/java/org/mozilla/reference/browser/tabs/synced/SyncedTabsAdapter.kt @@ -40,11 +40,13 @@ class SyncedTabsAdapter(private val listener: (SyncTab) -> Unit) : holder.bind(item, listener) } - override fun getItemViewType(position: Int): Int = - when (getItem(position)) { + override fun getItemViewType(position: Int): Int { + val item: AdapterItem = getItem(position) + return when (item) { is AdapterItem.Device -> DeviceViewHolder.LAYOUT_ID is AdapterItem.Tab -> TabViewHolder.LAYOUT_ID } + } private object DiffCallback : DiffUtil.ItemCallback() { override fun areItemsTheSame(