You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
?? only fires when the whole serverInfo object is absent (the modern-omitted case #1772 fixes). A server that reportsserverInfo: { name: "" } (an empty-but-present name) therefore yields serverInfo.name === "", and ViewHeader (ViewHeader.tsx:246) renders a nameless title — while the tab bar works fine.
The Connection Info modal already degrades gracefully here (serverInfo.name || "—", added in #1773); the header does not.
Needs a non-conforming-ish server (reports an empty name string) to reach.
The obvious fix (name: serverInfo?.name || activeServer?.name || "") would surface a catalog name while serverInfoReported is true, muddying the invariant that flag exists to keep clean — so it needs a deliberate decision about how serverInfoReported should behave in that case, not just a one-liner.
Suggested work
Decide the header's empty-reported-name behavior (degrade to catalog name? show "—"? and what serverInfoReported should then be), implement, and add an App test for a reported-but-empty name.
Summary
Follow-up from the #1773 (closes #1772) review. That PR's
initializeResultserverInfofallback is object-level:??only fires when the wholeserverInfoobject is absent (the modern-omitted case #1772 fixes). A server that reportsserverInfo: { name: "" }(an empty-but-present name) therefore yieldsserverInfo.name === "", andViewHeader(ViewHeader.tsx:246) renders a nameless title — while the tab bar works fine.The Connection Info modal already degrades gracefully here (
serverInfo.name || "—", added in #1773); the header does not.Why this is separate from #1772
name: serverInfo?.name || activeServer?.name || "") would surface a catalog name whileserverInfoReportedistrue, muddying the invariant that flag exists to keep clean — so it needs a deliberate decision about howserverInfoReportedshould behave in that case, not just a one-liner.Suggested work
Decide the header's empty-reported-name behavior (degrade to catalog name? show "—"? and what
serverInfoReportedshould then be), implement, and add an App test for a reported-but-empty name.