new top-level "Credits" section#13953
Open
drammock wants to merge 1 commit into
Open
Conversation
Member
|
FYI these errors are being fixed in #13938, which should merge imminently |
Member
|
Looks good to me! Style CIs are not happy with you though 😄 |
Member
Author
Time to take a look at our pre-commit config. There shouldn't be conflicts between what it wants and what style CI job wants |
Member
|
pre-commit also failed But the style job in general does run more stuff than pre-commit, IIRC for speed reasons (e.g. vulture is too slow to run on every commit and operates on the repository as a whole not individual files) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
doc/overview/people.rst)doc/credit.rst, which is auto-generated)doc/funding.rst)The main motivation for this is to make current support more prominent, as incentive to potential institutional sponsors (fewer homepage logos / dedicated "current sponsors" section == better visibility)