style(eforms): align Mine eForms page with property-workers pattern#7902
Merged
renemadsen merged 2 commits intoMay 24, 2026
Conversation
…rs pattern Wraps the page title, search, Tags dropdown and action buttons in a single mat-card.eform-sub-header. Tags dropdown is relocated from the mtx-grid toolbar slot into the header card so all filters live alongside the title and buttons, matching the property-workers reference. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Mine eForms page header layout to match the “property-workers” UI pattern by consolidating title + filters + actions into a single sub-header card and removing the now-unused mtx-grid toolbar template.
Changes:
- Replaced
<eform-new-subheader>+mtx-gridtoolbar template with amat-cardsub-header containing title, Search, Tags, and action buttons. - Added menu-driven page title resolution via
AppMenuStateService.leftAppMenus$andRouter.url. - Disabled the
mtx-gridtoolbar rendering ([showToolbar]="false") since the toolbar template was removed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eform-client/src/app/modules/eforms/components/eforms-page/eforms-page.component.ts | Adds menu-based page title resolution subscription; simplifies tag-loading code block. |
| eform-client/src/app/modules/eforms/components/eforms-page/eforms-page.component.html | Reworks header markup into a mat-card and removes mtx-grid toolbar template usage. |
Comment on lines
+150
to
+155
| // Resolve the page title once menus hydrate; recompute when they emit. | ||
| // getTitleByUrl reads from the menu store internally — we drive it from | ||
| // the menu emission instead of calling it per template change-detection. | ||
| this.titleSub$ = this.appMenuStateService.leftAppMenus$.subscribe(() => { | ||
| this.pageTitle = this.appMenuStateService.getTitleByUrl(this.router.url); | ||
| }); |
The Mine eForms page header was migrated from <eform-new-subheader> to <mat-card class="eform-sub-header"><h2>; update the playwright subheader + language tests and the matching cypress language test to target the new selector. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<eform-new-subheader>plus the standalone<ng-template #toolbarTpl>Tags dropdown with a singlemat-card.eform-sub-headercontaining the page title, Search, Tags dropdown, Import / Manage tags / New from XML / New eForm buttons in one right-aligned wrapping flex row.appMenuStateService.leftAppMenus$(mirroring the property-workers pattern).[showToolbar]="false", no[toolbarTemplate]).Test plan
/— title "Mine eForms" left-aligned at top of card; Search + Tags + Import + Manage tags + New from XML + New eForm right-aligned in one row.eformsCreateclaim, Import / XML / New eForm buttons should hide.🤖 Generated with Claude Code