Would contributor-facing architecture docs (doc/architecture/) be welcome? #6235
Unanswered
dimension-zero
asked this question in
Ideas
Replies: 1 comment
-
|
I would love to have something like this. I skimmed through what you have in your branch and it looks super helpful. If we got this we would probably want to link to it from I would change the name of |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi maintainers — wanted to check with the team before opening a PR.
While orienting myself to the codebase, I drafted three contributor-facing architecture documents describing the design at a higher level than the existing
doc/content. The goal was to make it easier for new contributors to form an accurate picture without reading the full source.Proposed location:
doc/architecture/Architecture.md — project layering, source/package/version abstractions, the
operator<<workflow composition pattern,ExecutionContext, COM surface, threading viaContextOrchestrator, REST protocol shape, and the installer security model.Configuration.md — the four-layer configuration precedence (Group Policy → admin settings → user settings → defaults), the
admin_settingsfile format, and the DSC subsystem (ConfigurationSet/Unit/Processor, schema evolution).Data.md — storage layout under
%LOCALAPPDATA%/%PROGRAMDATA%/%TEMP%, the role of each SQLite database (installed.db,pinning.db,config.db,index.db, checkpoints), the manifest cache, the ARP registry sources used to populate the installed catalog, and the install / source-update data flows.The documents deliberately avoid line numbers, exact field counts, and version-pinned details that would rot. They cross-reference the existing docs —
Settings.md,manifest.md,returnCodes.md, the policy reference, and the COM API spec — rather than duplicating content. The source of truth for specifics remains the code.Draft branch (read-only browse):
https://github.com/dimension-zero/winget-cli/tree/performance-improvements/doc/architecture
A few questions before I invest more time:
doc/architecture/the right location, or do you prefer somewhere else (or no subdirectory)?CONTRIBUTING.md?Thanks for taking a look.
Beta Was this translation helpful? Give feedback.
All reactions