From 9787b02580221f3e402e18f5bbbe1194ce0e5546 Mon Sep 17 00:00:00 2001 From: armahnii2000 <56534608+armahnii2000@users.noreply.github.com> Date: Thu, 7 May 2026 11:50:07 -0500 Subject: [PATCH 1/2] Apple frameworks: stamp CFBundleShortVersionString from $(MARKETING_VERSION) Replace hardcoded literal '1.0' for CFBundleShortVersionString with $(MARKETING_VERSION) in the four static Info.plist files used by libHttpClient's Apple framework targets. CFBundleVersion was already wired to $(CURRENT_PROJECT_VERSION). After this change, xcodebuild CLI overrides for MARKETING_VERSION/CURRENT_PROJECT_VERSION flow into both keys of the produced framework's Info.plist. Affects: - Utilities/FrameworkResources/Info_iOS.plist - Utilities/FrameworkResources/Info_mac.plist - Utilities/FrameworkResources/Info_NOWEBSOCKETS_iOS.plist - Utilities/FrameworkResources/Info_NOWEBSOCKETS_macOS.plist Default xcodeproj MARKETING_VERSION (1.0) is unchanged, so developer Xcode builds without an override behave exactly as today. Driven by the PlayFab Unified SDK Apple V2 release pipeline change to stamp consumer-readable versions on shipped frameworks. --- Utilities/FrameworkResources/Info_NOWEBSOCKETS_iOS.plist | 2 +- Utilities/FrameworkResources/Info_NOWEBSOCKETS_macOS.plist | 2 +- Utilities/FrameworkResources/Info_iOS.plist | 2 +- Utilities/FrameworkResources/Info_mac.plist | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Utilities/FrameworkResources/Info_NOWEBSOCKETS_iOS.plist b/Utilities/FrameworkResources/Info_NOWEBSOCKETS_iOS.plist index e1fe4cfb..82790df0 100644 --- a/Utilities/FrameworkResources/Info_NOWEBSOCKETS_iOS.plist +++ b/Utilities/FrameworkResources/Info_NOWEBSOCKETS_iOS.plist @@ -15,7 +15,7 @@ CFBundlePackageType FMWK CFBundleShortVersionString - 1.0 + $(MARKETING_VERSION) CFBundleVersion $(CURRENT_PROJECT_VERSION) diff --git a/Utilities/FrameworkResources/Info_NOWEBSOCKETS_macOS.plist b/Utilities/FrameworkResources/Info_NOWEBSOCKETS_macOS.plist index e1fe4cfb..82790df0 100644 --- a/Utilities/FrameworkResources/Info_NOWEBSOCKETS_macOS.plist +++ b/Utilities/FrameworkResources/Info_NOWEBSOCKETS_macOS.plist @@ -15,7 +15,7 @@ CFBundlePackageType FMWK CFBundleShortVersionString - 1.0 + $(MARKETING_VERSION) CFBundleVersion $(CURRENT_PROJECT_VERSION) diff --git a/Utilities/FrameworkResources/Info_iOS.plist b/Utilities/FrameworkResources/Info_iOS.plist index e1fe4cfb..82790df0 100644 --- a/Utilities/FrameworkResources/Info_iOS.plist +++ b/Utilities/FrameworkResources/Info_iOS.plist @@ -15,7 +15,7 @@ CFBundlePackageType FMWK CFBundleShortVersionString - 1.0 + $(MARKETING_VERSION) CFBundleVersion $(CURRENT_PROJECT_VERSION) diff --git a/Utilities/FrameworkResources/Info_mac.plist b/Utilities/FrameworkResources/Info_mac.plist index e1fe4cfb..82790df0 100644 --- a/Utilities/FrameworkResources/Info_mac.plist +++ b/Utilities/FrameworkResources/Info_mac.plist @@ -15,7 +15,7 @@ CFBundlePackageType FMWK CFBundleShortVersionString - 1.0 + $(MARKETING_VERSION) CFBundleVersion $(CURRENT_PROJECT_VERSION) From c653c04b65c0d1de43458a987c6326c22f2fce58 Mon Sep 17 00:00:00 2001 From: armahnii2000 <56534608+armahnii2000@users.noreply.github.com> Date: Fri, 8 May 2026 13:20:56 -0500 Subject: [PATCH 2/2] Apple frameworks: declare MARKETING_VERSION default at project level Adds MARKETING_VERSION = 1.0; to the project-level Debug and Release configs of libHttpClient.xcodeproj. Without this, after the previous commit replaced the literal '1.0' with $(MARKETING_VERSION) in the four static Info.plist files, builds that don't pass MARKETING_VERSION on the xcodebuild CLI (e.g. libHttpClient.CI, local Xcode developer builds) would resolve $(MARKETING_VERSION) to the empty string and ship CFBundleShortVersionString=''. With this default in place the framework targets that don't set their own MARKETING_VERSION inherit '1.0' from the project, matching pre-patch behavior. xcodebuild CLI overrides still take precedence over the project default, so release pipelines that pass MARKETING_VERSION=X.Y.Z continue to work. --- .../libHttpClient.xcodeproj/project.pbxproj | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Build/libHttpClient.Apple.C/libHttpClient.xcodeproj/project.pbxproj b/Build/libHttpClient.Apple.C/libHttpClient.xcodeproj/project.pbxproj index 728d5c9b..398d4aec 100644 --- a/Build/libHttpClient.Apple.C/libHttpClient.xcodeproj/project.pbxproj +++ b/Build/libHttpClient.Apple.C/libHttpClient.xcodeproj/project.pbxproj @@ -1757,6 +1757,7 @@ OTHER_CFLAGS = "-fembed-bitcode-marker"; PRODUCT_NAME = HttpClient; SDKROOT = macosx; + MARKETING_VERSION = 1.0; }; name = Debug; }; @@ -1815,6 +1816,7 @@ OTHER_CFLAGS = "-fembed-bitcode"; PRODUCT_NAME = HttpClient; SDKROOT = macosx; + MARKETING_VERSION = 1.0; }; name = Release; };