Skip to content

Fix: reserve dropdown popup scrollbar width to avoid suffix text crop… #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniketsahu07 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: reserve dropdown popup scrollbar width to avoid suffix text crop… #253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61768dd
Fix: reserve dropdown popup scrollbar width to avoid suffix text crop…
aniketsahu07 May 22, 2026
4c3065f
Fix(review): avoid double-reserving scrollbar width; reserve only whe…
aniketsahu07 May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/swt/DropdownPopup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ void open(Point location, List<DropdownItemGroup> groups, String selectedItemId,
populateGroups(container, groups);

Point contentSize = container.computeSize(SWT.DEFAULT, SWT.DEFAULT);
// Keep sizing simple here. If the popup becomes scrollable we reserve
// scrollbar width in constrainHeightIfNeeded(), avoiding double-reserving
// the width when the scrollbar is detected in both places.
container.setSize(contentSize);
scrolledComposite.setMinSize(contentSize);

Expand Down