From f942605c6010526609d56b177ffee0519b3aff87 Mon Sep 17 00:00:00 2001 From: "Patrick Nelson (VS)" Date: Fri, 24 Jul 2026 10:41:55 -0700 Subject: [PATCH 1/2] Fix link check - switched to using lychee --- .github/linters/check_links_config.json | 8 -------- .github/workflows/markdown-link-check.yml | 13 ++++++++----- docs/scenarios/azure.md | 1 - 3 files changed, 8 insertions(+), 14 deletions(-) delete mode 100644 .github/linters/check_links_config.json diff --git a/.github/linters/check_links_config.json b/.github/linters/check_links_config.json deleted file mode 100644 index 3b3d7d2b..00000000 --- a/.github/linters/check_links_config.json +++ /dev/null @@ -1,8 +0,0 @@ -{ - "ignorePatterns": [ - { - "pattern": "^https://www\\.microsoft\\.com.*" - } - ], - "aliveStatusCodes": [200, 203] -} \ No newline at end of file diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index 9ee54827..ebb66e83 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -20,9 +20,12 @@ jobs: with: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2 - - uses: gaurav-nelson/github-action-markdown-link-check@5c5dfc0ac2e225883c0e5f03a85311ec2830d368 # v1 + - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2 + + - name: Link Checker + uses: lycheeverse/lychee-action@e7477775783ea5526144ba13e8db5eec57747ce8 # v2.9.0 with: - config-file: .github/linters/check_links_config.json - use-quiet-mode: 'yes' - use-verbose-mode: 'no' \ No newline at end of file + args: '--no-progress --verbose ./**/*.md' + fail: false + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file diff --git a/docs/scenarios/azure.md b/docs/scenarios/azure.md index e2ef6103..0d043db5 100644 --- a/docs/scenarios/azure.md +++ b/docs/scenarios/azure.md @@ -169,7 +169,6 @@ leverage CLRIE and some do not. See [Application Insights Overview](https://docs.microsoft.com/azure/azure-monitor/app/app-insights-overview) Also refer to Application Insights extension - [design specs](https://github.com/Microsoft/InstrumentationEngine-Intercept/blob/develop/design-principles.md) From 5fbb6fcbd65a4256e3c8b2ff2f6383078f14ef98 Mon Sep 17 00:00:00 2001 From: "Patrick Nelson (VS)" Date: Fri, 24 Jul 2026 11:02:29 -0700 Subject: [PATCH 2/2] Fix pathing so all files are scanned --- .github/workflows/markdown-link-check.yml | 2 +- .lycheeignore | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .lycheeignore diff --git a/.github/workflows/markdown-link-check.yml b/.github/workflows/markdown-link-check.yml index ebb66e83..414cd4da 100644 --- a/.github/workflows/markdown-link-check.yml +++ b/.github/workflows/markdown-link-check.yml @@ -25,7 +25,7 @@ jobs: - name: Link Checker uses: lycheeverse/lychee-action@e7477775783ea5526144ba13e8db5eec57747ce8 # v2.9.0 with: - args: '--no-progress --verbose ./**/*.md' + args: "--no-progress --verbose './**/*.md'" fail: false env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file diff --git a/.lycheeignore b/.lycheeignore new file mode 100644 index 00000000..c8657088 --- /dev/null +++ b/.lycheeignore @@ -0,0 +1,8 @@ +# URLs excluded from markdown link checking (lychee). +# Each line is a regular expression matched against the link. + +# www.microsoft.com blocks automated requests and returns non-200 responses. +^https://www\.microsoft\.com.* + +# Not publicly resolvable: +^https://github\.com/Microsoft/InstrumentationEngine-Intercept.*