From 6c779ac03da9228f13215b3e13a91cdcb93f9147 Mon Sep 17 00:00:00 2001 From: Adesh Deshmukh Date: Wed, 17 Jun 2026 08:17:17 +0530 Subject: [PATCH 1/2] fix: preserve mainArtifact default on parse failure in import and import-url Signed-off-by: Adesh Deshmukh --- cmd/import.go | 6 +++--- cmd/importURL.go | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/cmd/import.go b/cmd/import.go index 2a8f8731..774b8a14 100644 --- a/cmd/import.go +++ b/cmd/import.go @@ -119,15 +119,15 @@ func NewImportCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command sepSpecificationFiles := strings.Split(specificationFiles, ",") for _, f := range sepSpecificationFiles { mainArtifact := true - var err error // Check if mainArtifact flag is provided. if strings.Contains(f, ":") { pathAndMainArtifact := strings.Split(f, ":") f = pathAndMainArtifact[0] - mainArtifact, err = strconv.ParseBool(pathAndMainArtifact[1]) - if err != nil { + if val, parseErr := strconv.ParseBool(pathAndMainArtifact[1]); parseErr != nil { fmt.Printf("Cannot parse '%s' as Bool, default to true\n", pathAndMainArtifact[1]) + } else { + mainArtifact = val } } diff --git a/cmd/importURL.go b/cmd/importURL.go index cb1640f7..1c0b28c8 100644 --- a/cmd/importURL.go +++ b/cmd/importURL.go @@ -108,9 +108,10 @@ func NewImportURLCommand(globalClientOpts *connectors.ClientOptions) *cobra.Comm if n > 2 { val, err := strconv.ParseBool(urlAndMainAtrifactAndSecretName[2]) if err != nil { - fmt.Println(err) + fmt.Printf("Cannot parse '%s' as Bool, default to true\n", urlAndMainAtrifactAndSecretName[2]) + } else { + mainArtifact = val } - mainArtifact = val } if n > 3 { secret = urlAndMainAtrifactAndSecretName[3] From 69e2cd5a23fac53cc2181cc011be49fd59f2a900 Mon Sep 17 00:00:00 2001 From: Adesh Deshmukh Date: Sun, 21 Jun 2026 17:40:30 +0530 Subject: [PATCH 2/2] fix(import): use LastIndex to safely handle paths with colons Signed-off-by: Adesh Deshmukh --- cmd/import.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cmd/import.go b/cmd/import.go index 774b8a14..e1e51a27 100644 --- a/cmd/import.go +++ b/cmd/import.go @@ -122,10 +122,11 @@ func NewImportCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command // Check if mainArtifact flag is provided. if strings.Contains(f, ":") { - pathAndMainArtifact := strings.Split(f, ":") - f = pathAndMainArtifact[0] - if val, parseErr := strconv.ParseBool(pathAndMainArtifact[1]); parseErr != nil { - fmt.Printf("Cannot parse '%s' as Bool, default to true\n", pathAndMainArtifact[1]) + lastColon := strings.LastIndex(f, ":") + boolPart := f[lastColon+1:] + f = f[:lastColon] + if val, parseErr := strconv.ParseBool(boolPart); parseErr != nil { + fmt.Printf("Cannot parse '%s' as Bool, default to true\n", boolPart) } else { mainArtifact = val }