Skip to content

Commit 9dc3a93

Browse files
dmealingclaude
andcommitted
fix(cli): a stale comment made a retired attribute look live to a grep (#337)
verify.ts:179 still named `verify.testFiles` as a thing the TS config supplies "for @Verifiedby". Both were deleted in 0.24.0 with the scan tier. Harmless as code — it is a comment — but NOT harmless as a shipped string: comments survive into `dist/*.js`, and an adopter grepping the rc.5 tarball for `@verifiedBy` cited exactly this file as evidence that "your own CLI reads it" (#337). It does not; there is no read anywhere, only this comment and the correct past-tense one at :454. Recorded because the failure mode generalises past this line: READERS ARRIVE BY GREP, not by reading top-down, so a surviving mention of retired vocabulary has to be self-evidently past-tense AT THE POINT OF MATCH. The same report quoted the agent-context doc the same way — landing mid-paragraph on "`@verifiedBy` asked you to name a test" while the heading two lines above reads "`verify` does not look at your tests", the sentence opens "It used to.", and the paragraph closes "The attribute is retired." That prose is correct and was still misread, which is the point. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 3868825 commit 9dc3a93

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • server/typescript/packages/cli/src/commands

server/typescript/packages/cli/src/commands/verify.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,8 @@ export async function verifyCommand(
176176
// The one thing NOT named by the metadata or its config: `metaobjects.config.ts`
177177
// is this TypeScript package's own answer to a different question (design §4.6),
178178
// so it gets its own nearest-ancestor walk and everything IT names follows —
179-
// `outDir`/`targets` for `--codegen`, `verify.testFiles` for `@verifiedBy`. In a
179+
// `outDir`/`targets` for `--codegen`. (It also carried `verify.testFiles` until
180+
// 0.24.0 retired the `@verifiedBy` scan; both are gone.) In a
180181
// Maven- or pip-rooted monorepo the collection is declared at the repo root while
181182
// the TS config sits in the app; reading the second from the first made
182183
// `--codegen` report "no config" for a package that has one (#326). Identical to

0 commit comments

Comments
 (0)