From e177f31411ff6ea090cf8172eff91ad0a9437b0a Mon Sep 17 00:00:00 2001 From: Taksh Date: Wed, 29 Jul 2026 22:08:55 +0300 Subject: [PATCH] fix: register workers with matching address in launch_all_serve model_worker uses --worker-address independently of --host/--port. launch_all_serve only forwarded host/port from model-path-address, so workers listening on custom ports still registered as localhost:21002. Co-authored-by: Cursor --- fastchat/serve/launch_all_serve.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/fastchat/serve/launch_all_serve.py b/fastchat/serve/launch_all_serve.py index 2f4ad7b0b..c527f06f7 100644 --- a/fastchat/serve/launch_all_serve.py +++ b/fastchat/serve/launch_all_serve.py @@ -47,7 +47,14 @@ parser.add_argument("--worker-host", type=str, default="localhost") parser.add_argument("--worker-port", type=int, default=21002) -# parser.add_argument("--worker-address", type=str, default="http://localhost:21002") +parser.add_argument( + "--worker-address", + type=str, + default=None, + help="Address registered with the controller. " + "Defaults to http://{worker-host}:{worker-port}; " + "overridden per worker from --model-path-address.", +) # parser.add_argument( # "--controller-address", type=str, default="http://localhost:21001" # ) @@ -129,6 +136,7 @@ worker_args = [ "worker-host", "worker-port", + "worker-address", "model-path", "revision", "device", @@ -242,6 +250,9 @@ def launch_worker(item): ) args.model_path, args.worker_host, args.worker_port = item.split("@") + # model_worker registers with --worker-address independently of --host/--port. + # Keep them aligned so the controller can reach the worker on the custom port. + args.worker_address = f"http://{args.worker_host}:{args.worker_port}" print("*" * 80) worker_str_args = string_args(args, worker_args) print(worker_str_args)