From 2aa5bde1f95aa77c579dce7f67d319d110083cbe Mon Sep 17 00:00:00 2001 From: Rick Staa Date: Mon, 10 Aug 2026 12:52:07 +0200 Subject: [PATCH] docs: prompt for forge tests and scope updates in the PR template `yarn test` is Hardhat only, so nothing currently prompts anyone to run the forge suite under src/test/. Those are the PoC and Fix pairs proving each past vulnerability is closed, and they are neither compiled nor run by CI. Also adds a reminder to update the Immunefi scope page when a deployed address changes. The L1Migrator redeployment on 2026-06-01 left the scope page pointing at the superseded contract for ten weeks. Switches the bold pseudo-headings to real markdown headings while here. Co-Authored-By: Claude Opus 5 (1M context) --- .github/PULL_REQUEST_TEMPLATE.md | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index fac45509..0d3e1836 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,22 +1,30 @@ -**What does this pull request do? Explain your changes. (required)** +## What does this pull request do? (required) + -**Specific updates (required)** - +## Specific updates (required) + + + - ... - ... - ... -**How did you test each of these updates (required)** +## How did you test each of these updates? (required) + +## Does this pull request close any open issues? -**Does this pull request close any open issues?** +## Checklist + + + -**Checklist:** - - - [ ] README and other documentation updated - [ ] All tests using `yarn test` pass +- [ ] `forge test` passes when `contracts/` or `src/test/` changed. Needs an archive + Arbitrum RPC; paste the summary line, or say why you could not run it. +- [ ] If any deployed address changed, the Immunefi scope page is updated