Add option for building without gui libs#549
Open
fekir wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #139
This MR adds an option for building timeshift without graphical libraries with following commands
I did not edit the packaging options, because I am not sure what is the best approach.
Two different binaries or two binaries with the same name?
If same name, should the packages be conflicting or the GUI version overwrite the command-line-only version? Or should the alternatives mechanism be used?
Are the answers the same for all distributions?
To keep it simple, I would prefer if this MR focuses on only adding the possibility on building timeshift without graphical libraries.
I also tried to minimize the diff, I suppose that by cleaning some things up it might be possible to remove one or two ifdefs, but I preferred to make the smallest and simplest change to ensure there are no regressions.