Laptop powers on automatically when plugging in AC power

[marmarek]

Please identify some basic details to help process the report

A. Provide Hardware Details

1. What board are you using? (Choose from the list of boards here)

x230

2. Does your computer have a dGPU or is it iGPU-only?

   • dGPU (Distinct GPU other then internal GPU)
   • iGPU-only (Internal GPU, normally Intel GPU)

3. Who installed Heads on this computer?

   • Insurgo (Issues to be reported at https://github.com/linuxboot/heads/issues)
   • Nitrokey (Issues to be reported at https://github.com/Nitrokey/heads/issues)
   • Purism (Issues to be reported at https://source.puri.sm/firmware/pureboot/-/issues)
   • Novacustom (Issues to be reported at https://github.com/Dasharo/dasharo-issues)
   • HardnenedVault (Issues to be reported at https://github.com/hardenedvault/vaultboot/issues)
   • Other provider
   • Self-installed

4. What PGP key is being used?

   • Librem Key (Nitrokey Pro 2 rebranded)
   • Nitrokey Pro
   • Nitrokey Pro 2
   • Nitrokey 3 NFC
   • Nitrokey 3 NFC Mini
   • Nitrokey Storage
   • Nitrokey Storage 2
   • Yubikey
   • Other

5. Are you using the PGP key to provide HOTP verification?

   • Yes
   • No
   • I don't know

B. Identify how the board was flashed

1. Is this problem related to updating heads or flashing it for the first time?

   • First-time flash
   • Updating heads

2. If the problem is related to an update, how did you attempt to apply the update?

   • Using the Heads menus
   • Flashrom via the Recovery Shell
   • External flashing

3. How was Heads initially flashed?

   • External flashing
   • Internal-only / 1vyprep+1vyrain / skulls
   • Don't know

4. Was the board flashed with a maximized or non-maximized/legacy rom?

   • Maximized
   • Non-maximized / legacy
   • I don't know

5. If Heads was externally flashed, was IFD unlocked?

   • Yes
   • No
   • Don't know

C. Identify the rom related to this bug report

1. Did you download or build the rom at issue in this bug report?

   • I downloaded it
   • I built it

2. If you downloaded your rom, where did you get it from?

   • Heads CircleCi
   • Purism
   • Nitrokey
   • Dasharo DTS (Novacustom)
   • Somewhere else (please identify)

Build from this PR: #1935

*Please provide the release number or otherwise identify the rom downloaded*

3. If you built your rom, which repository:branch did you use?

   • Heads:Master
   • Other (please identify)

4. What version of coreboot did you use in building?
   { You can find this information from github commit ID or once flashed, by giving the complete version from Sytem Information under Options --> menu}

5. In building the rom, where did you get the blobs?

   • No blobs required
   • Provided by the company that installed Heads on the device
   • Extracted from a backup rom taken from this device
   • Extracted from another backup rom taken from another device (please identify the board model)
   • Extracted from the online bios using the automated tools provided in Heads
   • I don't know

Please describe the problem

Describe the bug

When AC is connected, the laptop powers on automatically, without pressing the power button. Note, the battery here is not connected. I don't know how it behaves if battery would be there.

To be clear - I don't know if this is a bug, or intentional change. If it's intentional, I'm okay with this behavior too.

To Reproduce
Steps to reproduce the behavior:

1. Remove battery
2. Connect AC
3. Observe laptop booting already

Expected behavior

Previously it required pressing the power button. I know because openQA has it scripted - turn on AC and then press the button. After updating Heads, now that button press turns the already booting Heads off.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

Likely unrelated to the linked PR.
The version that didn't had this behavior was heads-x230-hotp-maximized_usb-kb-v0.2.0-2732-g4fa541e

[tlaurion]

Weird, nothing changed on configuratio side. Seems like coreboot 24.12 currently used changed behavior:

coreboot is supposed to leave power state to off after failing; seems like something changed in applying this.

[tlaurion]

@marmarek still an issue?