Commit 2b8318e
committed
feat(transcript): the collapsed activity header says what happened, not how many things
Reported against the Claude Code reference: a finished run collapsed to "3 steps", which
tells nobody anything, where the reference says "Ran 2 commands".
THE CAUSE was narrower than it looked. groupAggregate already builds a real sentence for
file work and commands — "Read and edited extension.js, ran a command". What it could not
describe were the SETUP steps: project rules, project memory, recall, skills, MCP. Those
arrive as pre-baked emoji chips, chipStep dropped every one of them into `note`, `note`
contributes no phrase, and a run made only of setup fell through to the bare count.
So they are classified now — rules / memory / recall / skill / mcp / mcpcall / preview —
and each contributes a phrase. The screenshot's run goes from
3 steps
to
Loaded project rules and memory, connected MCP tools
Two distinctions worth having:
- An MCP tool CALL (🔌 github · search_code) is different work from setup chatter about
servers (🔌 mcp · github (26) · 2/26 allow-listed). The first says "Called github", the
second "connected MCP tools". Collapsing them would let a run that actually used a
tool read as if it had only connected one.
- Setup is named LAST, so what changed still leads the sentence. A run that edited a file
and loaded rules reads "Edited a.ts, ran a command, loaded project rules" — a test pins
that ordering.
And the last-resort fallback names the first step and counts the rest ("Something unusual
happened and 1 more") rather than emitting a bare number. Sentence-cased like every other
path, which the first version was not.
The expanded steps now sit in one hairline container instead of loose rows under a heading
— closer to the reference, and it replaces a vertical cue rather than adding one: the group
already had a rail and a chevron, and a third was what made the expanded state look busy.
Bypass-verified: rules unrecognised; setup contributing no phrase; an MCP call lumped in
with setup; the fallback not sentence-cased; no setup kind detected at all.
groupAggregate and chipStep are now exposed on the test harness's api — they were extracted
into the sandbox but not reachable, so neither had ever been called directly by a test.
20 tests in groupReducer (was 16), 37 suites green.1 parent eda94c7 commit 2b8318e
2 files changed
Lines changed: 114 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
558 | 558 | | |
559 | 559 | | |
560 | 560 | | |
561 | | - | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
562 | 572 | | |
563 | 573 | | |
564 | 574 | | |
| |||
2054 | 2064 | | |
2055 | 2065 | | |
2056 | 2066 | | |
2057 | | - | |
| 2067 | + | |
| 2068 | + | |
| 2069 | + | |
| 2070 | + | |
| 2071 | + | |
| 2072 | + | |
| 2073 | + | |
| 2074 | + | |
| 2075 | + | |
| 2076 | + | |
| 2077 | + | |
| 2078 | + | |
| 2079 | + | |
| 2080 | + | |
| 2081 | + | |
| 2082 | + | |
| 2083 | + | |
| 2084 | + | |
| 2085 | + | |
| 2086 | + | |
| 2087 | + | |
| 2088 | + | |
| 2089 | + | |
| 2090 | + | |
| 2091 | + | |
| 2092 | + | |
| 2093 | + | |
| 2094 | + | |
| 2095 | + | |
| 2096 | + | |
| 2097 | + | |
2058 | 2098 | | |
2059 | 2099 | | |
2060 | 2100 | | |
| |||
2072 | 2112 | | |
2073 | 2113 | | |
2074 | 2114 | | |
| 2115 | + | |
| 2116 | + | |
| 2117 | + | |
| 2118 | + | |
| 2119 | + | |
| 2120 | + | |
| 2121 | + | |
| 2122 | + | |
| 2123 | + | |
| 2124 | + | |
| 2125 | + | |
| 2126 | + | |
| 2127 | + | |
| 2128 | + | |
2075 | 2129 | | |
2076 | 2130 | | |
2077 | 2131 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| |||
317 | 317 | | |
318 | 318 | | |
319 | 319 | | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
320 | 377 | | |
0 commit comments