Add TON case to contract_write executor#783
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
WalkthroughAdds TON blockchain support to the contract write executor by importing ChangesTON Contract Write Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Greptile SummaryThis PR adds TON blockchain support to the
Confidence Score: 4/5Safe to merge with a known gap around custom RPC support that has already been called out in a prior review thread. The TON handler is a straightforward, low-risk addition that mirrors the Solana and MultiversX contract-write paths exactly. The one meaningful gap — passing chainProviders.ton[operation.subchain] directly without checking operation.rpc — is already under discussion in a previous thread on this PR, so there are no new blocking issues to gate on. src/features/multichain/routines/executors/contract_write.ts — the RPC resolution logic warrants a second look once the prior thread on custom-RPC support is resolved. Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant handleContractWrite
participant handleTonContractWrite
participant genericJsonRpcPay
participant TON_SDK as TON SDK
Caller->>handleContractWrite: "operation (chain="ton")"
handleContractWrite->>handleTonContractWrite: operation
handleTonContractWrite->>genericJsonRpcPay: TON, chainProviders.ton[subchain], operation
genericJsonRpcPay->>TON_SDK: TON.create(rpcUrl)
TON_SDK-->>genericJsonRpcPay: instance
genericJsonRpcPay->>TON_SDK: instance.sendTransaction(signedPayloads[0])
TON_SDK-->>genericJsonRpcPay: result
genericJsonRpcPay-->>handleTonContractWrite: result
handleTonContractWrite-->>handleContractWrite: result
handleContractWrite-->>Caller: result
Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'origin/tes..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| // TON.sendTransaction parses it and broadcasts via TonCenter. | ||
| return await genericJsonRpcPay( | ||
| TON, | ||
| chainProviders.ton[operation.subchain], |
There was a problem hiding this comment.
operation.rpc fallback
chainProviders.ton[operation.subchain] is used directly without honoring a caller-supplied operation.rpc. The sibling handlePayOperation in pay.ts (line 52) uses operation.rpc || chainProviders[operation.chain][operation.subchain] for the same chain, so a custom RPC passed through a TON contract-write operation will be silently ignored. The same gap exists in handleSolanaContractWrite, but it's worth aligning both here.
| chainProviders.ton[operation.subchain], | |
| operation.rpc || chainProviders.ton[operation.subchain], |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/features/multichain/routines/executors/contract_write.ts`:
- Around line 35-43: The TON contract write handler handleTonContractWrite
currently always uses chainProviders.ton[operation.subchain], ignoring an
explicit operation.rpc override; update the provider selection so it prefers
operation.rpc when present (falling back to
chainProviders.ton[operation.subchain]) and pass that chosen provider into
genericJsonRpcPay (referencing handleTonContractWrite, operation.rpc,
chainProviders.ton, and genericJsonRpcPay to locate the change).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 42565c6c-7f90-4625-a716-062b115ab595
📒 Files selected for processing (1)
src/features/multichain/routines/executors/contract_write.ts
| async function handleTonContractWrite(operation: IOperation) { | ||
| // Signed payload is a hex-encoded BoC of the wallet's external message; the localSDK's | ||
| // TON.sendTransaction parses it and broadcasts via TonCenter. | ||
| return await genericJsonRpcPay( | ||
| TON, | ||
| chainProviders.ton[operation.subchain], | ||
| operation, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Honor operation.rpc in TON contract writes.
Line 40 always uses chainProviders.ton[operation.subchain], so explicit RPC overrides are ignored for TON writes. This can send transactions to the wrong endpoint/network in multi-env setups.
Suggested fix
async function handleTonContractWrite(operation: IOperation) {
// Signed payload is a hex-encoded BoC of the wallet's external message; the localSDK's
// TON.sendTransaction parses it and broadcasts via TonCenter.
+ const rpcUrl = operation.rpc || chainProviders.ton[operation.subchain]
return await genericJsonRpcPay(
TON,
- chainProviders.ton[operation.subchain],
+ rpcUrl,
operation,
)
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/features/multichain/routines/executors/contract_write.ts` around lines 35
- 43, The TON contract write handler handleTonContractWrite currently always
uses chainProviders.ton[operation.subchain], ignoring an explicit operation.rpc
override; update the provider selection so it prefers operation.rpc when present
(falling back to chainProviders.ton[operation.subchain]) and pass that chosen
provider into genericJsonRpcPay (referencing handleTonContractWrite,
operation.rpc, chainProviders.ton, and genericJsonRpcPay to locate the change).
…ntract-write-executor # Conflicts: # src/features/multichain/routines/executors/contract_write.ts
1 participant
Summary by CodeRabbit