From bb250549810f813e32a6c2b2303b6bb51cac461f Mon Sep 17 00:00:00 2001 From: Chris Fordham Date: Tue, 25 Aug 2026 13:03:52 +1000 Subject: [PATCH] fix(ci): quote the real version in the upgrade snippet [main] The release notes derive the version from --to, which is HEAD when notes are generated before the tag exists, so the upgrade command rendered: helm upgrade ... --version HEAD Pass the release version explicitly. The generator still falls back to --to, which is correct when --to is a tag. Verified in kube-workspaces/deploy, whose v0.2.2 notes hit this. --- .github/workflows/release.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 9402540..108e5c7 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -61,10 +61,12 @@ jobs: id: notes run: | set -euo pipefail + # --version, not just --to HEAD: the notes quote the version in the + # upgrade command, and "HEAD" is not installable. /tmp/release-notes.sh \ --repo "${GITHUB_REPOSITORY##*/}" \ --from "$(git describe --tags --abbrev=0)" \ - --to HEAD > /tmp/preamble.md + --to HEAD --version "${{ inputs.version }}" > /tmp/preamble.md cat /tmp/preamble.md - name: Summary