Skip to content

ci: guard updates for missing submodules#571

Merged
nuclearcat merged 1 commit into
mainfrom
agent/guard-missing-submodules
Jul 16, 2026
Merged

ci: guard updates for missing submodules#571
nuclearcat merged 1 commit into
mainfrom
agent/guard-missing-submodules

Conversation

@nuclearcat

Copy link
Copy Markdown
Member

What changed

Guard each external-submodule update so it only runs when the checked-out
submodule has its own .git marker.

Why

issue_comment workflows are loaded from the default branch, then the job
checks out the pull request head. A pull request that removes a submodule can
therefore run the older default-branch workflow against a tree where that
submodule no longer exists.

This caused staging deployment run 29489094118 to fail while trying to enter
kernelci.org/external/kernelci-core; kcidb would have failed next.

Impact

Existing submodules continue to update from their main branches. Removed or
uninitialized submodules are skipped, allowing submodule-removal pull requests
to use the staging deployment workflow safely.

Validation

  • Parsed .github/workflows/deploy.yml with PyYAML.
  • Ran git diff --check.
  • Verified missing or uninitialized submodule paths are skipped successfully.

@patersonc

Copy link
Copy Markdown
Collaborator

Hi @nuclearcat

Thanks for this. Do you want to add your SOB to the commit?

@patersonc

Copy link
Copy Markdown
Collaborator

/staging

@github-actions

Copy link
Copy Markdown

Your PR has been deployed to staging. Staging URL: https://static.staging.kernelci.org/ After testing, you can merge your PR. Note: This is a temporary staging URL, if anyone else will test another PR, it will override contents.

Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
@nuclearcat
nuclearcat force-pushed the agent/guard-missing-submodules branch from 0e52db0 to ba5fa58 Compare July 16, 2026 14:01
@nuclearcat
nuclearcat marked this pull request as ready for review July 16, 2026 14:03
@nuclearcat

Copy link
Copy Markdown
Member Author

I think it will refuse to touch/test workflows changes, i will merge as is and test another PR.

@nuclearcat
nuclearcat merged commit 2a70ad9 into main Jul 16, 2026
1 check passed
@nuclearcat
nuclearcat deleted the agent/guard-missing-submodules branch July 16, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants