Skip to content

Commit d0544b1

Browse files
committed
Fix ChoiceDialog disabled-state race and JUnit report job-name misattribution
- testChoiceDialogSelectsEnabledOptionAndSkipsDisabled read a freshly-opened dialog's render state right after waitFor { layerCount == 2 }, with no settle wait - the same missing-waitForComposeIdle() gap already fixed elsewhere in this suite. Added it before reading the disabled 'locked' choice's render state. - mikepenz/action-junit-report's job_name defaults to the raw job id ("check"), but matrix expansion names the actual check-run "check (fabric)"/"check (neoforge)" - since neither matches "check" exactly, the action's job lookup falls through and its annotations land on an unrelated job (observed: the docs workflow's job) instead of the check run they're actually for. Explicitly pass job_name: check (${{ matrix.loader }}) to match.
1 parent b431a37 commit d0544b1

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

.github/workflows/check.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@ jobs:
6767
uses: mikepenz/action-junit-report@v6
6868
with:
6969
check_name: JUnit Test Report (${{ matrix.loader }})
70+
# Matrix expansion names this job "check (fabric)"/"check (neoforge)", not just "check" -
71+
# without this, the action's default job_name (the raw job id "check") doesn't match any
72+
# actual check-run on this commit, and its annotations silently land on an unrelated job
73+
# (observed: the docs workflow's job) instead of failing loudly.
74+
job_name: check (${{ matrix.loader }})
7075
report_paths: '**/build/test-results/test/TEST-*.xml'
7176

7277
- name: Upload test reports

Archie/common/src/main/gametest/net/kernelpanicsoft/archie/gametest/internal/tests/ModalComponentsGameTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ class ModalComponentsGameTest {
9696
val triggers = baseLayer.rootNode { nodes("Button") }
9797
triggers[2] { click() } // "Open Choice"
9898
waitFor { _ -> layerCount == 2 }
99+
waitForComposeIdle()
99100

100101
node("Surface", layer = LayerSelector.Top) {
101102
val buttons = nodes("Button")

0 commit comments

Comments
 (0)