Termination condition

[pditommaso]

Can you elaborate about the need for a while loop in the awaitTermination method?

parallel_data_processor/src/main/java/es/jea/processor/DataProcessingFramework.java

Lines 49 to 51 in 4ed039b

	while (!executorService.isTerminated()){
	executorService.awaitTermination(TIMEOUT, TimeUnit.SECONDS);
	}

[jorgee]

The executor shutdown schedules the shutdown after all tasks have been finished. This call is non blocking so we need to do awaitTermination. This call require a timeout. The wait is to ensure processing takes more than the timeout

[pditommaso]

I see, but the timeout is expected to be provided as a protection to prevent a program from hanging forever if, for some reason, the termination condition cannot be reached.

I'd argue it could be better to avoid the use of the while (!executorService.isTerminated()) loop and eventually use a long timeout interval.