From 0202dbb2a9781ad93605ca0e1cceb79fece510f4 Mon Sep 17 00:00:00 2001 From: Mike Landau Date: Sun, 14 Jun 2026 21:55:44 -0700 Subject: [PATCH] ci: remove dead nix-version matrix from cli-tests test job The `test` job defined a 3-value `nix-version` matrix, but the value was never wired into any step after the job switched to installing Nix via devbox-install-action (which can't pin a Nix version). The three legs ran identical duplicates, tripling the slowest/flakiest job for no extra coverage. Remove the matrix and document how to re-add it once the install action supports specifying a Nix version. Cross-version coverage remains in the separate test-nix-versions job. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/cli-tests.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/cli-tests.yaml b/.github/workflows/cli-tests.yaml index 88bb7491077..57e51f68658 100644 --- a/.github/workflows/cli-tests.yaml +++ b/.github/workflows/cli-tests.yaml @@ -133,11 +133,14 @@ jobs: # the devbox.json tests. We can require the other tests to complete before # merging, while keeping the others as an additional non-required signal run-project-tests: ["project-tests-only", "project-tests-off"] - # Run tests on: - # 1. the oldest supported nix version (Nixpkgs requires >= 2.18 as of 2026) - # 2. nix 2.19.2: version before nix profile changes - # 3. latest nix version (note, 2.20.1 introduced a new profile change) - nix-version: ["2.18.0", "2.19.2", "2.30.2"] + # NOTE: this job used to run a `nix-version` matrix, but the + # devbox-install-action we now use to install Nix doesn't let us pin a + # specific Nix version. The matrix legs were therefore running identical + # duplicates (3x the jobs, 3x the flake surface, no extra coverage), so + # it was removed. Cross-version coverage is currently provided by the + # separate `test-nix-versions` job. Once the install action supports + # specifying a Nix version, re-add the matrix here and wire it into the + # "Install devbox" step. exclude: # Only runs tests on macos if explicitly requested, or on a schedule - os: "${{ (inputs.run-mac-tests || github.event.schedule != '') && 'dummy' || 'macos-latest' }}"