From ac715fb5298092be6ad453d546a9e46aca4207ed Mon Sep 17 00:00:00 2001 From: Nils Brederlow <62596379+dingodoppelt@users.noreply.github.com> Date: Sun, 5 Jul 2026 18:43:26 +0200 Subject: [PATCH 1/2] Refactor buffer.cpp to remove unused variable --- src/buffer.cpp | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/buffer.cpp b/src/buffer.cpp index 5e0e25f1f7..258c8323c4 100644 --- a/src/buffer.cpp +++ b/src/buffer.cpp @@ -91,11 +91,10 @@ void CNetBuf::Init ( const int iNewBlockSize, const int iNewNumBlocks, const boo else { // store current complete buffer state in temporary memory - CVector veciTempBlockValid ( iNumBlocksMemory ); - const uint8_t iOldSequenceNumberAtGetPos = iSequenceNumberAtGetPos; - const int iOldNumBlocksMemory = iNumBlocksMemory; - const int iOldBlockGetPos = iBlockGetPos; - int iCurBlockPos = 0; + CVector veciTempBlockValid ( iNumBlocksMemory ); + const int iOldNumBlocksMemory = iNumBlocksMemory; + const int iOldBlockGetPos = iBlockGetPos; + int iCurBlockPos = 0; while ( iBlockGetPos < iNumBlocksMemory && iCurBlockPos < iTempSize ) { @@ -113,8 +112,7 @@ void CNetBuf::Init ( const int iNewBlockSize, const int iNewNumBlocks, const boo Resize ( iNewNumBlocks, iNewBlockSize ); // write back the temporary data in new memory - iSequenceNumberAtGetPos = iOldSequenceNumberAtGetPos; - iBlockGetPos = 0; // per definition + iBlockGetPos = 0; // per definition for ( int iCurPos = 0; iCurPos < std::min ( iNewNumBlocks, iOldNumBlocksMemory ) && iCurPos < iTempSize; iCurPos++ ) { From 42f71930c7dda90f4456dd2102852fb8b5affa55 Mon Sep 17 00:00:00 2001 From: Nils Brederlow <62596379+dingodoppelt@users.noreply.github.com> Date: Sun, 5 Jul 2026 19:51:20 +0200 Subject: [PATCH 2/2] Fix formatting of variable declarations in buffer.cpp --- src/buffer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/buffer.cpp b/src/buffer.cpp index 258c8323c4..441b4121e4 100644 --- a/src/buffer.cpp +++ b/src/buffer.cpp @@ -92,9 +92,9 @@ void CNetBuf::Init ( const int iNewBlockSize, const int iNewNumBlocks, const boo { // store current complete buffer state in temporary memory CVector veciTempBlockValid ( iNumBlocksMemory ); - const int iOldNumBlocksMemory = iNumBlocksMemory; - const int iOldBlockGetPos = iBlockGetPos; - int iCurBlockPos = 0; + const int iOldNumBlocksMemory = iNumBlocksMemory; + const int iOldBlockGetPos = iBlockGetPos; + int iCurBlockPos = 0; while ( iBlockGetPos < iNumBlocksMemory && iCurBlockPos < iTempSize ) {