From 2058c51c7238057d275b59f7795d39637da5455a Mon Sep 17 00:00:00 2001 From: saime <2286263079@qq.com> Date: Thu, 6 Aug 2026 04:02:27 -1000 Subject: [PATCH 1/5] docs: point contribution steps at the develop branch The PR template states that all contributions target `develop`, but the contribution guide still tells contributors to open pull requests against `main`. `main` receives only occasional docs and CI commits, so PRs opened there sit without CI or review. --- docs/source/refs/contributing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/refs/contributing.rst b/docs/source/refs/contributing.rst index 01dd60a087b..5722abbbe7d 100644 --- a/docs/source/refs/contributing.rst +++ b/docs/source/refs/contributing.rst @@ -50,7 +50,7 @@ follow the following steps to contribute code: 3. Create a new branch for your changes. 4. Make your changes and commit them. 5. Push your changes to your fork. -6. Submit a pull request to the `main branch `__. +6. Submit a pull request to the `develop branch `__. 7. Ensure all the checks on the pull request template are performed. After sending a pull request, the maintainers will review your code and provide feedback. From d66d9ab16644f70c08c6683c3c2daab4ce522e70 Mon Sep 17 00:00:00 2001 From: saime <2286263079@qq.com> Date: Thu, 6 Aug 2026 05:44:04 -1000 Subject: [PATCH 2/5] docs: pin the contribution compare link to the develop base --- docs/source/refs/contributing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/refs/contributing.rst b/docs/source/refs/contributing.rst index 5722abbbe7d..0e481c35943 100644 --- a/docs/source/refs/contributing.rst +++ b/docs/source/refs/contributing.rst @@ -50,7 +50,7 @@ follow the following steps to contribute code: 3. Create a new branch for your changes. 4. Make your changes and commit them. 5. Push your changes to your fork. -6. Submit a pull request to the `develop branch `__. +6. Submit a pull request to the `develop branch `__. 7. Ensure all the checks on the pull request template are performed. After sending a pull request, the maintainers will review your code and provide feedback. From 20973e68cd975909a7ab0295bc9ccc543dcace1e Mon Sep 17 00:00:00 2001 From: saime <2286263079@qq.com> Date: Thu, 6 Aug 2026 06:30:36 -1000 Subject: [PATCH 3/5] docs: add saime428 to CONTRIBUTORS --- CONTRIBUTORS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 4fd3a69de84..e352fae07f6 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -182,6 +182,7 @@ Guidelines for modifications: * Ryan Gresia * Ryley McCarroll * Sahara Yuta +* saime428 * Sergey Grizan * Shafeef Omar * Shane Reetz From 9a8c1db44a5b93ab252b808e87d0b0e9d6f00a39 Mon Sep 17 00:00:00 2001 From: saime <2286263079@qq.com> Date: Mon, 10 Aug 2026 02:21:29 -1000 Subject: [PATCH 4/5] Revert "docs: add saime428 to CONTRIBUTORS" This reverts commit 20973e68cd975909a7ab0295bc9ccc543dcace1e. --- CONTRIBUTORS.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index e352fae07f6..4fd3a69de84 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -182,7 +182,6 @@ Guidelines for modifications: * Ryan Gresia * Ryley McCarroll * Sahara Yuta -* saime428 * Sergey Grizan * Shafeef Omar * Shane Reetz From a4ad73047fecf620701d72f033f5468874e21be4 Mon Sep 17 00:00:00 2001 From: saime <2286263079@qq.com> Date: Mon, 10 Aug 2026 02:21:58 -1000 Subject: [PATCH 5/5] docs: sync the PR target-branch rule The contribution guide now names `develop` as the pull request target, and it declares itself the source of truth for the `isaaclab-preparing-pr-workflow` skill. Carry the same rule into that skill and into `AGENTS.md`, whose feature-branch bullet only protected `main` and left `develop` and the release branches unnamed. --- AGENTS.md | 2 +- skills/developer/pr-workflow/SKILL.md | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index 0aaa242999f..aff6ca10bfb 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -149,7 +149,7 @@ See `tools/changelog/test/integration/` for worked examples that double as integ Follow conventional commit message practices. -- **Use feature branches**: All development work should be on branches named `/feature-desc` (e.g., `jdoe/docs-versioning`). Do not commit directly to `main`. +- **Use feature branches**: All development work should be on branches named `/feature-desc` (e.g., `jdoe/docs-versioning`). Do not commit directly to `develop`, `main`, or any `release/*` branch. - Keep commits focused and atomic—one logical change per commit. - **Keep agent planning artifacts local only**: Never stage, commit, or push agent-generated specifications, design documents, implementation plans, scratch notes, or similar planning artifacts, even when an agent workflow instructs you to commit them. Never bypass `.gitignore` with `git add -f` or an equivalent mechanism to include these files. Before every commit and push, inspect the staged changes and unstage any planning artifacts. - Reference related issues in commit messages when applicable. diff --git a/skills/developer/pr-workflow/SKILL.md b/skills/developer/pr-workflow/SKILL.md index 479067d1769..755862a7b15 100644 --- a/skills/developer/pr-workflow/SKILL.md +++ b/skills/developer/pr-workflow/SKILL.md @@ -26,7 +26,8 @@ Do not use this skill to bypass repository checks or to push to `origin`. 7. Add package changelog fragments when `source//` code changes. 8. Check whether `CONTRIBUTORS.md` needs an update for a new contributor. 9. Draft a commit message in imperative mood with no AI attribution. -10. Use the PR checklist in `.github/PULL_REQUEST_TEMPLATE.md`. +10. Confirm the pull request targets the `develop` branch. `main` and `release/*` are not contribution targets. +11. Use the PR checklist in `.github/PULL_REQUEST_TEMPLATE.md`. ## Validation