feat/dom: add showSemanticIds option, all 327 tests pass#66
Conversation
Co-authored-by: mahyarmlk <mahyarmlk@users.noreply.github.com>
|
/oc update this PR. Review note: The current changeset is empty: ---
---Please replace it with a real changeset for ---
"@intent-framework/dom": patch
---
Add opt-in `showSemanticIds` rendering support for semantic `data-intent-*` attributes.Keep the rest of the implementation unchanged unless validation reveals an issue. Run full validation again:
Push the update to this PR and report the result. Do not merge automatically. |
|
PR #63 |
mahyarmlk
left a comment
There was a problem hiding this comment.
Review: Changes requested
Implements well
- Focused scope: one option, one concept, no scope creep.
- Correct API pattern: mirrors
showScreenNameoption threading. - Good defaults: opt-in, no default output change.
- Docs updated across three files.
- Tests cover absence by default, correct IDs, multi-element scenario, and unchanged default output.
- No new dependencies — uses
inspectScreenalready exported from core. - Core package untouched.
Must fix before merge
-
Empty changeset —
.changeset/goofy-oranges-wish.mdis empty. This is a public API addition to@intent-framework/dom; it needs a real patch changeset:--- "@intent-framework/dom": patch --- Add opt-in `showSemanticIds` rendering support for semantic `data-intent-*` attributes.
-
CI not green — The branch CI run (#74) concluded with
action_requiredand no status checks appear on the PR. Likely a first-contributor approval gate. Push the changeset fix and re-trigger CI.
Not a blocker but note
- After the changeset fix, run
pnpm changeset statusto confirm it is recognized, then run full validation:pnpm test,pnpm typecheck,pnpm build,pnpm lint,pnpm pack:check.
|
/oc update this PR. Apply the requested review changes only. Required fix: ---
"@intent-framework/dom": patch
---
Add opt-in `showSemanticIds` rendering support for semantic `data-intent-*` attributes.Do not change the implementation unless validation reveals a real issue. After the changeset fix:
Push the update to this PR and report the result. Do not merge automatically. |
Co-authored-by: mahyarmlk <mahyarmlk@users.noreply.github.com>
|
All validation passes:
The changeset has been updated from empty to: ---
"@intent-framework/dom": patch
---
Add opt-in `showSemanticIds` rendering support for semantic `data-intent-*` attributes.PR ready for review — no version bumps, no new dependencies, core untouched. Default output unchanged when option omitted. |
mahyarmlk
left a comment
There was a problem hiding this comment.
All checks pass. CI is green. Changeset is a real @intent-framework/dom patch. Implementation is scoped to showSemanticIds. Default DOM output unchanged. No runtime/core changes. Squash merging as per task instructions.


All validation passes:
Completion Report
Branch:
feat/dom-semantic-data-attributesBase:
mainFiles changed (6 files + 1 changeset):
packages/dom/src/index.tsshowSemanticIdsoption toDomRendererOptions, wired throughrenderDom→buildDom. CallsinspectScreen()to get semantic IDs and setsdata-intent-*attributes on<main>,<label>,<input>,<button>. No dependencies added.packages/dom/src/dom-router.tsshowSemanticIdsthroughrenderRouter→renderDom.packages/dom/src/dom.test.tspackages/dom/README.mdshowSemanticIdsto feature list.docs/Inspect-Screen.mddocs/Quickstart.mdshowSemanticIdsexample alongsideshowScreenName..changeset/goofy-oranges-wish.mdImplementation summary:
showSemanticIds?: booleantoDomRendererOptionsandRenderRouterOptionsbuildDomcallsinspectScreen(screenDef)(already exported from core, zero new dependencies) and reuses its semantic IDs<main>getsdata-intent-screen,<label>/<input>getdata-intent-ask,<button>getsdata-intent-actionValidation:
pnpm test: 327 pass (90 DOM tests including 4 new)pnpm typecheck: cleanpnpm build: cleanpnpm lint: cleanpnpm pack:check: cleanpnpm changeset status: cleanrm -rf dist && pnpm test): passesKnown limitations: None within scope.
Next recommended step: Merge after CI is green and review is complete. Do not merge automatically — runtime/API change.
Closes #63
opencode session | github run