Upstream PR review item from has2k1#1059.
Source review comments:
Requested change:
- Move the functionality currently in
facet.set_limits_breaks_and_labels into the coord class, probably as coord.setup_ax.
- Let coord subclasses override
setup_ax completely or call super() and add coord-specific behavior.
- Remove now-unnecessary coord/facet helper methods once
coord.setup_ax owns this behavior.
Review goal: give custom coord classes a clearer extension point and keep coord-specific behavior inside coord modules.
Upstream PR review item from has2k1#1059.
Source review comments:
coord_polarandcoord_radial. has2k1/plotnine#1059 (comment)coord_polarandcoord_radial. has2k1/plotnine#1059 (comment)Requested change:
facet.set_limits_breaks_and_labelsinto thecoordclass, probably ascoord.setup_ax.setup_axcompletely or callsuper()and add coord-specific behavior.coord.setup_axowns this behavior.Review goal: give custom coord classes a clearer extension point and keep coord-specific behavior inside coord modules.