Skip to content

Move axis setup from facet into coord.setup_ax #2

@iangow

Description

@iangow

Upstream PR review item from has2k1#1059.

Source review comments:

Requested change:

  • Move the functionality currently in facet.set_limits_breaks_and_labels into the coord class, probably as coord.setup_ax.
  • Let coord subclasses override setup_ax completely or call super() and add coord-specific behavior.
  • Remove now-unnecessary coord/facet helper methods once coord.setup_ax owns this behavior.

Review goal: give custom coord classes a clearer extension point and keep coord-specific behavior inside coord modules.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions