Skip to content

Move coord projection selection onto coord classes #1

@iangow

Description

@iangow

Upstream PR review item from has2k1#1059.

Source review comments:

Requested change:

  • Add a projection property to the base coord class, likely _projection: str | None = None.
  • Set _projection = "polar" on coord_polar and any radial/polar subclasses that need Matplotlib polar axes.
  • Update facet subplot creation to use projection=self.plot.coordinates._projection instead of special-casing coordinate classes in facet.py.

Review goal: limit the external footprint of custom coord classes outside their own modules.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions