Upstream PR review item from has2k1#1059.
Source review comments:
Requested change:
- Add a projection property to the base
coord class, likely _projection: str | None = None.
- Set
_projection = "polar" on coord_polar and any radial/polar subclasses that need Matplotlib polar axes.
- Update facet subplot creation to use
projection=self.plot.coordinates._projection instead of special-casing coordinate classes in facet.py.
Review goal: limit the external footprint of custom coord classes outside their own modules.
Upstream PR review item from has2k1#1059.
Source review comments:
coord_polarandcoord_radial. has2k1/plotnine#1059 (comment)coord_polarandcoord_radial. has2k1/plotnine#1059 (comment)Requested change:
coordclass, likely_projection: str | None = None._projection = "polar"oncoord_polarand any radial/polar subclasses that need Matplotlib polar axes.projection=self.plot.coordinates._projectioninstead of special-casing coordinate classes infacet.py.Review goal: limit the external footprint of custom coord classes outside their own modules.