Reviewed the code for work and proposing some fixes and changes.

[dbongartz]

Hi!

Thanks for open sourcing this library!

I am looking to use it at work and started reviewing the code (only for the Rust part). I realize this is still WIP but it is already useful for me.

My initial round resulted in these PR's:

• feat: improve rust codegen #4
• Improve Msg and GeneratedCanMessage API #5
• Simplify the BigEndian (start, end) calculation #6
• Clarify CLI and Config API #7
• Fix many (not all) clippy::pedantic warnings. #8
• Bump dependencies #9

Happy to discuss them if anything is unclear or unwanted :)

[kilpkonn]

Thank you very much for the contributions!

I've left couple of comments to PRs.
Some of them are kind of nitpicks so feel free to challenge them if you don't agree.

Btw what made you consider this WIP, cuz afaik this seems kind of complete.
Maybe we forgot something we don't use ourselves :D

[dbongartz]

Thanks for the quick responses :)

Oh, I'm sorry! I didn't want to sound like it's incomplete. Maybe I should have phrased it as "young" :)

Code is well readable, I didn't find any obvious critical bugs or immediate features missing. So definitely production ready :)

I was more judging by adoption and refinement. The latter obviously would come from more adoption and contributors. Some things I did notice though:

• There are some TODO comments and the story around integer conversions/parsing, types for the scaled values and range checking still wants a closer look I feel.
• I have a slightly broken DBC file that was interpreted differently by other tools for signed integers which scale to the limits. Something like: SG_ FOO : 16|8@1- (1,200) [200|328] "" VECTOR__XXX.
• CI/CD testing isn't setup for PR's but for push to main. Maybe that's intended though :)

I am on holidays starting next week but will have a closer look at some of these things as soon as I am back.

Again, thanks for making this project available, it saves me a bunch of work and from the time saved I can contribute a bit back :)