From c3601140c62648dc0a26800bcca728c1f4100bd3 Mon Sep 17 00:00:00 2001 From: Mark Nottingham Date: Tue, 9 Jun 2026 14:06:39 +1000 Subject: [PATCH] Make vary-3-order isolate header order The test reordered headers but also changed Bar's value, so the value mismatch (not the ordering) forced not_cached and order-independence was never exercised. Send the stored values in a different order and expect reuse, so an order-sensitive cache would fail to match. Closes #170 Co-Authored-By: Claude Opus 4.8 --- tests/vary.mjs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/vary.mjs b/tests/vary.mjs index ead194c..a41be2d 100644 --- a/tests/vary.mjs +++ b/tests/vary.mjs @@ -245,19 +245,20 @@ export default { ] }, { - name: "HTTP cache must not reuse three-way `Vary` response when request doesn't match, regardless of header order", + name: 'An optimal HTTP cache reuses a three-way `Vary` response regardless of request header order', id: 'vary-3-order', spec_anchors: ['caching.negotiated.responses'], depends_on: ['vary-3-match'], + kind: 'optimal', requests: [ vary3Setup({}), { request_headers: [ ['Foo', '1'], ['Baz', '789'], - ['Bar', 'abcde'] + ['Bar', 'abc'] ], - expected_type: 'not_cached' + expected_type: 'cached' } ] },