Pause only when pause_after is true, not merely present#172
Conversation
pauseAfter was set from `'pause_after' in requests[i]`, so a request with `pause_after: false` would still pause. Compare against true. Closes #166 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ReviewVerdict: Approve. The fix is correct and resolves #166 with no behavioral regression for any test that exists today. Correctness against existing behaviorWalking the truth table for the changed expression at
The two cases that occur in practice ( Downstream consistencyThe consumer at line 62 already gates on "Latent" claim — verifiedI grepped the whole tree: every one of the 100+ One edge case worth noting (not blocking)This is a slight semantic narrowing for truthy non-boolean values: under the old code ScopeOne-line change, no collateral edits, CI passing. Clean. This is an AI-generated review (Claude Code), produced as part of a maintainer-directed review of the test suite and relayed by the maintainer. |
Fixes #166:
pauseAfterwas computed from'pause_after' in requests[i], sopause_after: falsewould still trigger a pause. Now compares the value againsttrue.Latent today (templates only ever set
true), but removes the no-op trap for anyone overriding a template tofalse.Closes #166
🤖 This PR was generated by an AI agent (Claude Code) under human supervision, as part of a maintainer-directed review of the test suite.