From 996c6e2d4749afb42f33e573ea780657b290cc12 Mon Sep 17 00:00:00 2001
From: Vance Ingalls <vance@heygen.com>
Date: Fri, 21 Aug 2026 00:04:51 -0700
Subject: [PATCH 1/2] refactor(producer): delete the dead audioExtractor
 duplicate
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`packages/producer/src/services/audioExtractor.ts` defined its own
`parseAudioElements` and a `processAudio` that nothing calls. Every live
consumer — `audioMixer.ts` (a pure re-export), `renderMediaCollector.ts`, the
playback-rate parity fixture — imports these from `@hyperframes/engine`
instead, so the file was a second, silently diverging copy of an engine
decision.

That divergence was already a bug: PRINFRA-349's review flagged this file's
hand-rolled `startsWith("/")` source-path join as the same percent-encoded-CJK
failure fixed in the HDR probes, with no decode, no compiledDir and no Windows
`isAbsolute`. Engine's resolver has all three. Deleting the copy is the fix —
patching it would have kept a resolver nobody reaches.
---
 .../producer/src/services/audioExtractor.ts   | 323 ------------------
 1 file changed, 323 deletions(-)
 delete mode 100644 packages/producer/src/services/audioExtractor.ts

diff --git a/packages/producer/src/services/audioExtractor.ts b/packages/producer/src/services/audioExtractor.ts
deleted file mode 100644
index 6e6f0fa65d..0000000000
--- a/packages/producer/src/services/audioExtractor.ts
+++ /dev/null
@@ -1,323 +0,0 @@
-// fallow-ignore-file unused-file code-duplication complexity
-/**
- * Audio Extractor Service
- *
- * Extracts audio from media elements in the composition HTML,
- * applies timeline positioning, and mixes into a single audio track.
- */
-
-import { spawn } from "node:child_process";
-import { existsSync, mkdirSync, rmSync, readFileSync } from "node:fs";
-import { join, dirname } from "node:path";
-import { getFfmpegBinary, trackChildProcess } from "@hyperframes/engine";
-
-export interface AudioElement {
-  id: string;
-  src: string;
-  start: number;
-  duration: number;
-  mediaStart: number;
-  volume: number;
-  tagName: "audio" | "video";
-}
-
-export interface AudioTrack {
-  id: string;
-  srcPath: string;
-  start: number;
-  duration: number;
-  mediaStart: number;
-  volume: number;
-}
-
-/**
- * Parse audio/video elements from HTML to find media with audio.
- */
-export function parseAudioElements(html: string): AudioElement[] {
-  const elements: AudioElement[] = [];
-
-  // Match <audio> and <video> elements with data-start
-  const mediaRegex = /<(audio|video)\s[^>]*data-start=["']([^"']+)["'][^>]*>/gi;
-  let match;
-
-  while ((match = mediaRegex.exec(html)) !== null) {
-    const fullTag = match[0];
-    const tagName = (match[1] ?? "").toLowerCase() as "audio" | "video";
-    const start = parseFloat(match[2] ?? "");
-
-    // `(?<![\w-])` keeps the plain-id pattern off `data-hf-render-id="…"` (and
-    // `data-hf-id`), which would otherwise match first and report the wrong id.
-    const idMatch = fullTag.match(/(?<![\w-])id=["']([^"']+)["']/);
-    const renderIdMatch = fullTag.match(/data-hf-render-id=["']([^"']+)["']/);
-    const srcMatch = fullTag.match(/src=["']([^"']+)["']/);
-    if (!srcMatch) continue;
-
-    const durationMatch = fullTag.match(/data-duration=["']([^"']+)["']/);
-    const endMatch = fullTag.match(/data-end=["']([^"']+)["']/);
-    const mediaStartMatch = fullTag.match(/data-media-start=["']([^"']+)["']/);
-    const volumeMatch = fullTag.match(/data-volume=["']([^"']+)["']/);
-    const parsedVolume = volumeMatch ? parseFloat(volumeMatch[1] ?? "") : 1.0;
-    const safeVolume = Number.isFinite(parsedVolume) ? parsedVolume : 1.0;
-    const durationFromDuration = durationMatch ? parseFloat(durationMatch[1] ?? "") : NaN;
-    const end = endMatch ? parseFloat(endMatch[1] ?? "") : NaN;
-    const duration =
-      !isNaN(durationFromDuration) && durationFromDuration > 0
-        ? durationFromDuration
-        : !isNaN(end) && end > start
-          ? end - start
-          : 0;
-
-    elements.push({
-      // The stamped render id is document-unique; the authored id is only
-      // unique within one composition file. See core's mediaRenderIds.ts.
-      id: renderIdMatch?.[1] || idMatch?.[1] || `media-${elements.length}`,
-      src: srcMatch[1] ?? "",
-      start: isNaN(start) ? 0 : start,
-      duration,
-      mediaStart: mediaStartMatch ? parseFloat(mediaStartMatch[1] ?? "") : 0,
-      volume: safeVolume,
-      tagName,
-    });
-  }
-
-  return elements;
-}
-
-/**
- * Run an FFmpeg command and return a promise.
- */
-function runFFmpeg(args: string[]): Promise<void> {
-  return new Promise((resolve, reject) => {
-    const ffmpeg = spawn(getFfmpegBinary(), args);
-    trackChildProcess(ffmpeg);
-    let stderr = "";
-
-    ffmpeg.stderr.on("data", (data) => {
-      stderr += data.toString();
-    });
-
-    ffmpeg.on("close", (code) => {
-      if (code === 0) {
-        resolve();
-      } else {
-        reject(new Error(`FFmpeg failed (code ${code}): ${stderr.slice(-500)}`));
-      }
-    });
-
-    ffmpeg.on("error", (err) => {
-      reject(err);
-    });
-  });
-}
-
-/**
- * Extract audio from a single media file.
- */
-async function extractAudioTrack(
-  srcPath: string,
-  outputPath: string,
-  playbackStart: number,
-  duration: number,
-): Promise<boolean> {
-  const outputDir = dirname(outputPath);
-  if (!existsSync(outputDir)) {
-    mkdirSync(outputDir, { recursive: true });
-  }
-
-  const args: string[] = [];
-
-  if (playbackStart > 0) {
-    args.push("-ss", String(playbackStart));
-  }
-
-  if (duration > 0) {
-    args.push("-t", String(duration));
-  }
-
-  args.push(
-    "-i",
-    srcPath,
-    "-vn",
-    "-acodec",
-    "pcm_s16le",
-    "-ar",
-    "48000",
-    "-ac",
-    "2",
-    "-y",
-    outputPath,
-  );
-
-  try {
-    await runFFmpeg(args);
-    return true;
-  } catch (err) {
-    console.warn(
-      `[AudioExtractor] Failed to extract audio from ${srcPath}: ${
-        err instanceof Error ? err.message : err
-      }`,
-    );
-    return false;
-  }
-}
-
-/**
- * Generate a silence audio file.
- */
-async function generateSilence(outputPath: string, duration: number): Promise<void> {
-  const outputDir = dirname(outputPath);
-  if (!existsSync(outputDir)) {
-    mkdirSync(outputDir, { recursive: true });
-  }
-
-  await runFFmpeg([
-    "-f",
-    "lavfi",
-    "-i",
-    "anullsrc=r=48000:cl=stereo",
-    "-t",
-    String(duration),
-    "-acodec",
-    "pcm_s16le",
-    "-y",
-    outputPath,
-  ]);
-}
-
-/**
- * Mix multiple audio tracks with timeline positioning.
- */
-async function mixTracks(
-  tracks: AudioTrack[],
-  outputPath: string,
-  totalDuration: number,
-): Promise<void> {
-  if (tracks.length === 0) {
-    await generateSilence(outputPath, totalDuration);
-    return;
-  }
-
-  const outputDir = dirname(outputPath);
-  if (!existsSync(outputDir)) {
-    mkdirSync(outputDir, { recursive: true });
-  }
-
-  const inputs: string[] = [];
-  const filterParts: string[] = [];
-
-  tracks.forEach((track, i) => {
-    inputs.push("-i", track.srcPath);
-
-    const delayMs = Math.round(track.start * 1000);
-    const trimDuration = track.duration > 0 ? track.duration : totalDuration;
-
-    // See audioMixer.ts for why asetpts sits between apad and atrim.
-    filterParts.push(
-      `[${i}:a]atrim=0:${trimDuration},volume=${track.volume},adelay=${delayMs}|${delayMs},apad,asetpts=N/SR/TB,atrim=0:${totalDuration}[a${i}]`,
-    );
-  });
-
-  const mixInputs = tracks.map((_, i) => `[a${i}]`).join("");
-  // amix divides by track count by default (normalize=true). Compensate with
-  // a volume gain to preserve per-track levels across all FFmpeg versions.
-  const mixFilter = `${mixInputs}amix=inputs=${tracks.length}:duration=longest[mixed]`;
-  const postMixGain = `[mixed]volume=${tracks.length}[out]`;
-  const fullFilter = [...filterParts, mixFilter, postMixGain].join(";");
-
-  const args = [
-    ...inputs,
-    "-filter_complex",
-    fullFilter,
-    "-map",
-    "[out]",
-    "-acodec",
-    "aac",
-    "-b:a",
-    "192k",
-    "-t",
-    String(totalDuration),
-    "-y",
-    outputPath,
-  ];
-
-  await runFFmpeg(args);
-}
-
-/**
- * Process all audio for a composition.
- *
- * @param htmlPath - Path to the composition HTML (for parsing media elements)
- * @param projectDir - Base directory for resolving relative media paths
- * @param workDir - Temporary working directory for intermediate files
- * @param outputPath - Final mixed audio output path
- * @param totalDuration - Total composition duration in seconds
- * @returns true if audio was produced, false if no audio elements found
- */
-export async function processAudio(
-  htmlPath: string,
-  projectDir: string,
-  workDir: string,
-  outputPath: string,
-  totalDuration: number,
-): Promise<boolean> {
-  const html = readFileSync(htmlPath, "utf-8");
-  const elements = parseAudioElements(html);
-
-  if (elements.length === 0) {
-    console.log("[AudioExtractor] No audio elements found");
-    return false;
-  }
-
-  console.log(`[AudioExtractor] Processing ${elements.length} audio element(s)...`);
-
-  if (!existsSync(workDir)) {
-    mkdirSync(workDir, { recursive: true });
-  }
-
-  const tracks: AudioTrack[] = [];
-
-  for (const element of elements) {
-    // Resolve source path relative to project directory
-    let srcPath = element.src;
-    if (!srcPath.startsWith("/") && !srcPath.startsWith("http")) {
-      srcPath = join(projectDir, srcPath);
-    }
-
-    if (!existsSync(srcPath)) {
-      console.warn(`[AudioExtractor] Source not found: ${srcPath}`);
-      continue;
-    }
-
-    const extractedPath = join(workDir, `${element.id}-extracted.wav`);
-    const success = await extractAudioTrack(
-      srcPath,
-      extractedPath,
-      element.mediaStart,
-      element.duration,
-    );
-
-    if (success) {
-      tracks.push({
-        id: element.id,
-        srcPath: extractedPath,
-        start: element.start,
-        duration: element.duration,
-        mediaStart: element.mediaStart,
-        volume: element.volume,
-      });
-    }
-  }
-
-  console.log(`[AudioExtractor] Mixing ${tracks.length} track(s) into final audio...`);
-  await mixTracks(tracks, outputPath, totalDuration);
-
-  // Clean up work directory
-  try {
-    rmSync(workDir, { recursive: true, force: true });
-  } catch {
-    // Ignore cleanup errors
-  }
-
-  console.log("[AudioExtractor] Audio processing complete");
-  return true;
-}

From bc432698679a98df0d8c7fd87158491be82e54a1 Mon Sep 17 00:00:00 2001
From: Vance Ingalls <vance@heygen.com>
Date: Fri, 21 Aug 2026 00:23:16 -0700
Subject: [PATCH 2/2] chore: record the audioExtractor deletion in the
 no-deletions guard
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`check-no-main-deletions.mjs` fails any branch that removes a file main has,
by design — the guard has no blanket escape hatch, so an intended removal is a
named, reviewable line. This adds that line with the reason.
---
 scripts/check-no-main-deletions.mjs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/check-no-main-deletions.mjs b/scripts/check-no-main-deletions.mjs
index b3fb5209da..2ab38e0ae0 100644
--- a/scripts/check-no-main-deletions.mjs
+++ b/scripts/check-no-main-deletions.mjs
@@ -97,6 +97,10 @@ export const ALLOWED_DELETIONS = new Map([
     "packages/core/scripts/build-position-edits-render.ts",
     "merged into build-inline-artifact.ts, same reason as build-audio-fx-runtime.ts above",
   ],
+  [
+    "packages/producer/src/services/audioExtractor.ts",
+    "dead duplicate of engine's audioMixer: its processAudio had no callers and its parseAudioElements was shadowed by the @hyperframes/engine export every live consumer already imports (audioMixer.ts re-exports it, renderMediaCollector.ts and the playback-rate fixture import it directly). PRINFRA-349's review found the copy's hand-rolled source-path join reproducing the percent-encoded-CJK bug the engine resolver does not have — deleting the copy is the fix",
+  ],
   [
     "packages/core/scripts/build-inline-artifact.ts",
     "a later branch in this stack (wa-20b2-lfo-fixes) independently deduped the same two build scripts a different way — buildInjectedArtifact.ts plus two thin per-target files — before this consolidation and that one had merged; this branch's tree keeps that shape instead, so build-inline-artifact.ts is the one that goes.",