refactor: replace all println/eprintln with tracing#14
Open
markovejnovic wants to merge 10 commits into
Open
Conversation
- Remove unused ui_println/ui_eprintln macros - Add #[must_use] to CliLayer::real() - Allow type_complexity in cli_layer tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CliLayertracing subscriber that routesuser::stdout/user::stderrtargets to the correct output streams with no tracing metadata decorationprintln!/eprintln!/print!/eprint!occurrences acrosshmandhm-plugin-cloudcrates withtracing::info!(target: "user::*", ...)callsCliLayer(user-facing output) + optionalfmtlayer (diagnostic tracing,--verboseonly)tracing/tracing-subscriberas workspace dependenciesclippy::print_stdoutandclippy::print_stderrlints fromwarntodenyArchitecture
Two-layer subscriber:
user::stdout→ stdout,user::stderr→ stderr, no decorationEdge case: clap help/version/error text uses raw
std::io::Writewith scoped#[allow](2 occurrences inhm-plugin-cloud/src/cli.rs).Test Plan
cargo clippy --workspaceclean — zero print lint violationscmd_run_local_autoselectfailures confirmed unrelated (missing Pythonharmontmodule)hm --versionprints to stdouthm --verbose --versionshows diagnostic output on stderrhm runerror output appears on stderr with styling