Skip to content

e2e: project-picker-recent-search.spec.ts skipped on the fork — port to a v2 projects surface #120

Description

@aarontrowbridge

Upstream's v1.18.12 spec packages/app/e2e/regression/project-picker-recent-search.spec.ts (search-across-all-recent-projects, #40202) is skipped on the fork as of the 1.18.12 sync (#119).

Why: the spec drives upstream's home-projects surface — an "Add project" button on the home page opening DialogSelectDirectory. The fork does not render that surface:

  • NewHome (the Amicode v2 home, ADR 0001) has no add-project entry point — projects live in a titlebar flyout without an add affordance.
  • The legacy interface is compile-time retired in this build (packages/app/src/context/settings.tsx: newLayoutDesigns = createMemo(() => true)), so the legacy home the spec could have driven is unreachable.
  • home-projects-view.tsx (upstream's surface with the button) ships as dead code here — nothing renders <HomeProjects>.

What still ships: the v1.18.12 five-cap + search-all logic itself (dialog-select-directory.tsx, upstream 3016830e2) — reachable via every useDirectoryPicker consumer. Only the e2e coverage of it is fork-blocked.

Re-enable path: when a v2 projects surface gains an add-project entry, restore the spec with the fork's entry selector; or cover DialogSelectDirectory at component level. Local archaeology (seeds, layout-migration clobber, page snapshots) is in the #119 discussion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions