Skip to content
This repository was archived by the owner on May 10, 2018. It is now read-only.
This repository was archived by the owner on May 10, 2018. It is now read-only.

Typescript --strictFunctionTypes parameter incompatibility #64

@stephentuso

Description

@stephentuso

Edit: This only happens with strictFunctionTypes. Seems like it would be good to support that

Using binding-ts, I'm getting some errors in the generated ts file:

generated/starchive-api.ts(28,3): error TS2416: Property 'query' in type 'Binding' is not assignable to the same property in base type 'Binding<QueryMap, SubscriptionMap>'.
  Type 'Query' is not assignable to type 'QueryMap'.
    Property 'helloWorld' is incompatible with index signature.
      Type '(args: {}, context: { [key: string]: any; }, info?: string | GraphQLResolveInfo | undefined) => P...' is not assignable to type '(args?: { [key: string]: any; } | undefined, context?: { [key: string]: any; } | undefined, info?...'.
        Types of parameters 'args' and 'args' are incompatible.
          Type '{ [key: string]: any; } | undefined' is not assignable to type '{}'.
            Type 'undefined' is not assignable to type '{}'.

Am I missing something? All the parameters in QueryMap are optional so shouldn't the generated

export type Query = {
  helloWorld: (args: {}, context: { [key: string]: any }, info?: GraphQLResolveInfo | string) => Promise<String | null>
}

actually be this?

export type Query = {
  helloWorld: (args?: {}, context?: { [key: string]: any }, info?: GraphQLResolveInfo | string) => Promise<String | null>
}

However, making that change causes another issue because Binding#delegate doesn't have optional parameters either

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions