From 06ad5fd6434177f6093239ed15ebad755f94d41a Mon Sep 17 00:00:00 2001 From: Jaycee Li Date: Thu, 27 Aug 2026 00:07:21 -0700 Subject: [PATCH] chore: keep config as the last method parameter PiperOrigin-RevId: 971764800 --- src/converters/_memorybanks_converters.ts | 10 +++++----- src/converters/_skills_converters.ts | 10 +++++----- src/types/common.ts | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/converters/_memorybanks_converters.ts b/src/converters/_memorybanks_converters.ts index 351a5143..e2e1fdc6 100644 --- a/src/converters/_memorybanks_converters.ts +++ b/src/converters/_memorybanks_converters.ts @@ -40,11 +40,6 @@ export function createMemoryBankRequestParametersToVertex( ): Record { const toObject: Record = {}; - const fromConfig = common.getValueByPath(fromObject, ['config']); - if (fromConfig != null) { - createMemoryBankConfigToVertex(fromConfig, toObject); - } - const fromMemoryBankConfig = common.getValueByPath(fromObject, [ 'memoryBankConfig', ]); @@ -56,6 +51,11 @@ export function createMemoryBankRequestParametersToVertex( ); } + const fromConfig = common.getValueByPath(fromObject, ['config']); + if (fromConfig != null) { + createMemoryBankConfigToVertex(fromConfig, toObject); + } + return toObject; } diff --git a/src/converters/_skills_converters.ts b/src/converters/_skills_converters.ts index 8fe0d67b..1628ea74 100644 --- a/src/converters/_skills_converters.ts +++ b/src/converters/_skills_converters.ts @@ -44,16 +44,16 @@ export function createSkillRequestParametersToVertex( common.setValueByPath(toObject, ['description'], fromDescription); } - const fromConfig = common.getValueByPath(fromObject, ['config']); - if (fromConfig != null) { - createSkillConfigToVertex(fromConfig, toObject); - } - const fromSkillId = common.getValueByPath(fromObject, ['skillId']); if (fromSkillId != null) { common.setValueByPath(toObject, ['_query', 'skillId'], fromSkillId); } + const fromConfig = common.getValueByPath(fromObject, ['config']); + if (fromConfig != null) { + createSkillConfigToVertex(fromConfig, toObject); + } + return toObject; } diff --git a/src/types/common.ts b/src/types/common.ts index a42888cd..8a7f6792 100644 --- a/src/types/common.ts +++ b/src/types/common.ts @@ -1228,8 +1228,8 @@ export declare interface CreateMemoryBankConfig { /** Parameters for creating memory banks. */ export declare interface CreateMemoryBankRequestParameters { - config?: CreateMemoryBankConfig; memoryBankConfig?: ReasoningEngineContextSpecMemoryBankConfig; + config?: CreateMemoryBankConfig; } /** The configuration for generating memories. */ @@ -3364,11 +3364,11 @@ export declare interface CreateSkillRequestParameters { displayName: string; /** Required. The description of the Skill. */ description: string; - config?: CreateSkillConfig; /** Required. The ID to use for the Skill, which will become the final component of the Skill's resource name. */ skillId: string; + config?: CreateSkillConfig; } /** Operation that has a skill as a response. */