From ca64daad95b3a392fec3a93641a9f4cc26613260 Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Thu, 25 Jun 2026 18:37:37 +0000 Subject: [PATCH 1/4] test: remove kokoro system tests for bigquery-storage --- .../.kokoro/continuous/node18/system-test.cfg | 12 ---- .../.kokoro/presubmit/node18/system-test.cfg | 12 ---- .../bigquery-storage/.kokoro/system-test.sh | 61 ------------------- .../bigquery-storage/.kokoro/trampoline_v2.sh | 2 +- handwritten/bigquery-storage/owlbot.py | 6 +- 5 files changed, 6 insertions(+), 87 deletions(-) delete mode 100644 handwritten/bigquery-storage/.kokoro/continuous/node18/system-test.cfg delete mode 100644 handwritten/bigquery-storage/.kokoro/presubmit/node18/system-test.cfg delete mode 100755 handwritten/bigquery-storage/.kokoro/system-test.sh diff --git a/handwritten/bigquery-storage/.kokoro/continuous/node18/system-test.cfg b/handwritten/bigquery-storage/.kokoro/continuous/node18/system-test.cfg deleted file mode 100644 index 25f57eb1376d..000000000000 --- a/handwritten/bigquery-storage/.kokoro/continuous/node18/system-test.cfg +++ /dev/null @@ -1,12 +0,0 @@ -# Download resources for system tests (service account key, etc.) -gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" - -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/nodejs-bigquery-storage/handwritten/bigquery-storage/.kokoro/system-test.sh" -} - -env_vars: { - key: "SECRET_MANAGER_KEYS" - value: "long-door-651-kokoro-system-test-service-account" -} \ No newline at end of file diff --git a/handwritten/bigquery-storage/.kokoro/presubmit/node18/system-test.cfg b/handwritten/bigquery-storage/.kokoro/presubmit/node18/system-test.cfg deleted file mode 100644 index 25f57eb1376d..000000000000 --- a/handwritten/bigquery-storage/.kokoro/presubmit/node18/system-test.cfg +++ /dev/null @@ -1,12 +0,0 @@ -# Download resources for system tests (service account key, etc.) -gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/google-cloud-nodejs" - -env_vars: { - key: "TRAMPOLINE_BUILD_FILE" - value: "github/nodejs-bigquery-storage/handwritten/bigquery-storage/.kokoro/system-test.sh" -} - -env_vars: { - key: "SECRET_MANAGER_KEYS" - value: "long-door-651-kokoro-system-test-service-account" -} \ No newline at end of file diff --git a/handwritten/bigquery-storage/.kokoro/system-test.sh b/handwritten/bigquery-storage/.kokoro/system-test.sh deleted file mode 100755 index a90d5cfec89e..000000000000 --- a/handwritten/bigquery-storage/.kokoro/system-test.sh +++ /dev/null @@ -1,61 +0,0 @@ -#!/bin/bash - -# Copyright 2018 Google LLC -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# https://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -set -eo pipefail - -export NPM_CONFIG_PREFIX=${HOME}/.npm-global - -# Setup service account credentials. -export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/secret_manager/long-door-651-kokoro-system-test-service-account -export GCLOUD_PROJECT=long-door-651 - -cd $(dirname $0)/.. - -# Run a pre-test hook, if a pre-system-test.sh is in the project -if [ -f .kokoro/pre-system-test.sh ]; then - set +x - . .kokoro/pre-system-test.sh - set -x -fi - -npm install - -# If tests are running against main branch, configure flakybot -# to open issues on failures: -if [[ $KOKORO_BUILD_ARTIFACTS_SUBDIR = *"continuous"* ]] || [[ $KOKORO_BUILD_ARTIFACTS_SUBDIR = *"nightly"* ]]; then - export MOCHA_REPORTER_OUTPUT=test_output_sponge_log.xml - export MOCHA_REPORTER=xunit - cleanup() { - chmod +x $KOKORO_GFILE_DIR/linux_amd64/flakybot - $KOKORO_GFILE_DIR/linux_amd64/flakybot - } - trap cleanup EXIT HUP -fi - -npm run system-test - -# codecov combines coverage across integration and unit tests. Include -# the logic below for any environment you wish to collect coverage for: -COVERAGE_NODE=18 -if npx check-node-version@3.3.0 --silent --node $COVERAGE_NODE; then - NYC_BIN=./node_modules/nyc/bin/nyc.js - if [ -f "$NYC_BIN" ]; then - $NYC_BIN report || true - fi - bash $KOKORO_GFILE_DIR/codecov.sh -else - echo "coverage is only reported for Node $COVERAGE_NODE" -fi diff --git a/handwritten/bigquery-storage/.kokoro/trampoline_v2.sh b/handwritten/bigquery-storage/.kokoro/trampoline_v2.sh index 92312d4d09c6..6e5f7bccfbe5 100755 --- a/handwritten/bigquery-storage/.kokoro/trampoline_v2.sh +++ b/handwritten/bigquery-storage/.kokoro/trampoline_v2.sh @@ -45,7 +45,7 @@ # # Here is an example for running this script. # TRAMPOLINE_IMAGE=gcr.io/cloud-devrel-kokoro-resources/node:18-user \ -# TRAMPOLINE_BUILD_FILE=.kokoro/system-test.sh \ +# TRAMPOLINE_BUILD_FILE=.kokoro/samples-test.sh \ # .kokoro/trampoline_v2.sh set -euo pipefail diff --git a/handwritten/bigquery-storage/owlbot.py b/handwritten/bigquery-storage/owlbot.py index 3738dd2f5ad2..b2b43d8e61ca 100644 --- a/handwritten/bigquery-storage/owlbot.py +++ b/handwritten/bigquery-storage/owlbot.py @@ -15,5 +15,9 @@ import synthtool.languages.node_mono_repo as node node.owlbot_main(relative_dir="handwritten/bigquery-storage", - templates_excludes=['src/index.ts', 'README.md'] + templates_excludes=[ + 'src/index.ts', + 'README.md', + '.kokoro/system-test.sh' + ] ) From bbb3f070cdfb1a6e54d11ca4c6c041dfbf105e5f Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Thu, 25 Jun 2026 15:28:39 -0400 Subject: [PATCH 2/4] exclude more deleted files from the bigquery-stora --- handwritten/bigquery-storage/owlbot.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/handwritten/bigquery-storage/owlbot.py b/handwritten/bigquery-storage/owlbot.py index b2b43d8e61ca..d05aaeb9062c 100644 --- a/handwritten/bigquery-storage/owlbot.py +++ b/handwritten/bigquery-storage/owlbot.py @@ -14,10 +14,12 @@ """This script is used to synthesize generated parts of this library.""" import synthtool.languages.node_mono_repo as node -node.owlbot_main(relative_dir="handwritten/bigquery-storage", +node.owlbot_main(relative_dir="handwritten/bigquery-storage", templates_excludes=[ 'src/index.ts', 'README.md', - '.kokoro/system-test.sh' + '.kokoro/system-test.sh', + '.kokoro/continuous/node18/system-test.cfg', + '.kokoro/presubmit/node18/system-test.cfg', ] ) From 49192e5ccdf2c0bdb026c0ed4d051edf5c46bd34 Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Fri, 26 Jun 2026 10:08:35 -0400 Subject: [PATCH 3/4] =?UTF-8?q?Don=E2=80=99t=20exclude=20kokoro=20files?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- handwritten/bigquery-storage/owlbot.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/handwritten/bigquery-storage/owlbot.py b/handwritten/bigquery-storage/owlbot.py index d05aaeb9062c..204599d23c5e 100644 --- a/handwritten/bigquery-storage/owlbot.py +++ b/handwritten/bigquery-storage/owlbot.py @@ -15,11 +15,5 @@ import synthtool.languages.node_mono_repo as node node.owlbot_main(relative_dir="handwritten/bigquery-storage", - templates_excludes=[ - 'src/index.ts', - 'README.md', - '.kokoro/system-test.sh', - '.kokoro/continuous/node18/system-test.cfg', - '.kokoro/presubmit/node18/system-test.cfg', - ] + templates_excludes=['src/index.ts','README.md'] ) From 2173ab4f6d33bd7f9a6ce1a61dde6630ac6675bd Mon Sep 17 00:00:00 2001 From: Daniel Bruce Date: Fri, 26 Jun 2026 10:12:21 -0400 Subject: [PATCH 4/4] Add spaces back --- handwritten/bigquery-storage/owlbot.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/handwritten/bigquery-storage/owlbot.py b/handwritten/bigquery-storage/owlbot.py index 204599d23c5e..3738dd2f5ad2 100644 --- a/handwritten/bigquery-storage/owlbot.py +++ b/handwritten/bigquery-storage/owlbot.py @@ -14,6 +14,6 @@ """This script is used to synthesize generated parts of this library.""" import synthtool.languages.node_mono_repo as node -node.owlbot_main(relative_dir="handwritten/bigquery-storage", - templates_excludes=['src/index.ts','README.md'] +node.owlbot_main(relative_dir="handwritten/bigquery-storage", + templates_excludes=['src/index.ts', 'README.md'] )