[bot] Merge master/bf412f54 into rel/dev#1673
Merged
Merged
Conversation
Wrap Rich Console.print() calls in _make_progress_callbacks with a threading.Lock. Without this, concurrent ThreadPoolExecutor workers deadlock when stdout is piped (e.g. background process). The lock serializes only the print calls — actual evaluation work remains fully concurrent. Add test_progress_callbacks_thread_safe to verify callbacks can be called from 8 concurrent threads without errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fix(eval): thread-safe progress callbacks for --concurrency
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1673 +/- ##
========================================
Coverage 79.21% 79.21%
========================================
Files 232 232
Lines 15809 15809
========================================
Hits 12523 12523
Misses 3286 3286 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to bf412f5 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/28102245222).