feat(gooddata-sdk): [AUTO] Add organization dataCenter and region diagnostic deployment fields#1578
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Add organization dataCenter and region diagnostic deployment fields#1578yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…gnostic deployment fields
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
===========================================
+ Coverage 0.00% 78.66% +78.66%
===========================================
Files 158 230 +72
Lines 11048 15420 +4372
===========================================
+ Hits 0 12130 +12130
+ Misses 11048 3290 -7758 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added data_center and region diagnostic deployment fields to CatalogOrganizationAttributes. Both fields are read from the API response (JsonApiOrganizationOutAttributes already contains them in the generated client) but excluded from write requests via a custom to_api() override, since they are absent from JsonApiOrganizationInAttributes. Four unit tests added covering field storage, to_api() exclusion, from_api() population, and graceful handling of absent fields.
Impact: new_feature | Services:
gooddata-metadata-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/organization.pypackages/gooddata-sdk/tests/catalog/test_catalog_organization.pyAgent decisions
Decisions (3)
placement of data_center and region — Add to CatalogOrganizationAttributes alongside the other organization attributes
excluding read-only fields from write requests — Override to_api() in CatalogOrganizationAttributes to explicitly construct JsonApiOrganizationInAttributes with only writable fields
no init.py export change — Leave CatalogOrganizationAttributes unexported
Assumptions to verify (3)
Risks (2)
Layers touched (2)
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/organization.pypackages/gooddata-sdk/tests/catalog/test_catalog_organization.pySource commits (gdc-nas)
f0f3783feat(metadata-api): add deployment info to API2577b31Merge pull request #21385 from Vojtasii/vto/deployment-infoOpenAPI diff
"JsonApiOrganizationOutAttributes": { "properties": { + "dataCenter": { + "description": "Data center identifier for diagnostic purposes.", + "type": "string" + }, + "region": { + "description": "Region identifier for diagnostic purposes.", + "type": "string" + }, "hostname": { "type": "string" } } }Workflow run
Generated by SDK OpenAPI Sync workflow