feat(gooddata-sdk): [AUTO] Add WRITE/READ_KNOWLEDGE_DOCUMENTS and BASE_UI_ACCESS permissions#1569
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Add WRITE/READ_KNOWLEDGE_DOCUMENTS and BASE_UI_ACCESS permissions#1569yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…E_UI_ACCESS permissions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1569 +/- ##
===========================================
+ Coverage 0.00% 78.66% +78.66%
===========================================
Files 158 230 +72
Lines 11048 15405 +4357
===========================================
+ Hits 0 12118 +12118
+ Misses 11048 3287 -7761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added test_organization_permission_validation to test_catalog_permission.py to cover the new BASE_UI_ACCESS org permission value. No SDK wrapper source changes were needed: the auto-generated gooddata-api-client already carries WRITE_KNOWLEDGE_DOCUMENTS, READ_KNOWLEDGE_DOCUMENTS (WorkspacePermission), and BASE_UI_ACCESS (OrganizationPermission) in its allowed_values dicts, and the SDK wrapper uses the dynamic value_in_allowed validator that reads those dicts at runtime.
Impact: enum_addition | Services:
gooddata-metadata-clientFiles changed
packages/gooddata-sdk/tests/catalog/test_catalog_permission.pyAgent decisions
Decisions (2)
no SDK wrapper source changes — Set status to implemented (test addition only) rather than no_changes
test approach for enum addition — Unit test using existing _validation_helper pattern without cassettes
Assumptions to verify (3)
Layers touched (1)
packages/gooddata-sdk/tests/catalog/test_catalog_permission.pySource commits (gdc-nas)
ba12e35feat: enforce knowledge document permissions7c52d90feat(afm-exec-api): gate knowledge APIs with enableAIKnowledge3d58a73Merge pull request #20450 from peter-plochan/perm/base-ui-accessOpenAPI diff
"WorkspacePermission": { "enum": [ "ANALYZE", + "READ_KNOWLEDGE_DOCUMENTS", + "WRITE_KNOWLEDGE_DOCUMENTS", "VIEW" ] }, "OrganizationPermission": { "enum": [ + "BASE_UI_ACCESS", "MANAGE", "SELF_SERVICE_ENTITLEMENTS" ] }Workflow run
Generated by SDK OpenAPI Sync workflow