feat(gooddata-sdk): [AUTO] Add LlmProvider entity (Bedrock/Azure/OpenAI) and deprecate LlmEndpoint#1566
Open
yenkins-admin wants to merge 2 commits intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Add LlmProvider entity (Bedrock/Azure/OpenAI) and deprecate LlmEndpoint#1566yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
…AI) and deprecate LlmEndpoint
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1566 +/- ##
===========================================
+ Coverage 0.00% 78.70% +78.70%
===========================================
Files 158 230 +72
Lines 11048 15436 +4388
===========================================
+ Hits 0 12149 +12149
+ Misses 11048 3287 -7761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added CatalogResolvedLlm and CatalogListLlmProviderModelsResponse response model classes; added resolve_llm_providers() to CatalogWorkspaceContentService and list_llm_provider_models_by_id() to CatalogOrganizationService; exported both new classes from the public init.py; wrote 4 unit tests (no cassettes) and 1 integration test stub. The LlmProvider entity CRUD (get/list/create/update/delete) was already fully implemented; no LlmEndpoint SDK wrappers existed to deprecate.
Impact: deprecation | Services:
gooddata-metadata-clientFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/organization/service.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/content_service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_organization.pyAgent decisions
Decisions (4)
resolve_llm_providers placement — Added to CatalogWorkspaceContentService (workspace-scoped)
list_llm_provider_models_by_id placement — Added to CatalogOrganizationService (org-scoped)
Response class inheritance — CatalogResolvedLlm and CatalogListLlmProviderModelsResponse do NOT extend Base
LlmEndpoint deprecation handling — No SDK changes for LlmEndpoint deprecation
Assumptions to verify (4)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/organization/service.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/content_service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_organization.pySource commits (gdc-nas)
31290c9Merge pull request #21147 from hkad98/jkd/llm-endpoint-to-provider-phase1f15a954Merge pull request #21038 from hkad98/jkd/llm-providera19eb19Merge pull request #21393 from hkad98/jkd/llm-endpoint-deprecation699c75cMerge pull request #21420 from hkad98/jkd/resolve-llm-provider456d25aMerge pull request #21526 from gooddata/jkd/llm-provider-sync-default-onc84a24aMerge pull request #21232 from hkad98/jkd/llm-provider-setting6fe3b97Merge pull request #20938 from hkad98/jkd/llm-provider-model-listing151ac81Merge pull request #21566 from gooddata/rkis/phase4-pr9b-remaining-org-modele06d415Merge pull request #21533 from gooddata/rkis/phase4-pr9a-org-model-controllers6d6b21fMerge pull request #21127 from gooddata/rkis/entity-controllers-phase2e822d57Merge pull request #21064 from gooddata/rkis/entity-controllers-phase1OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow