Skip to content

[v3.52.0 regression] Tests fail when built from source archive #2907

Description

@ReillyBrogan

Description

I was updating the AerynOS package to the latest version when I saw that the test suite now fails. As far as I can tell this is caused by using the Github-generated source archive for building go-task (which is typical for distribution packages as it's much more easily cached) and introduced by 616433d. Likely all of the failing tests should be skipped if running from a non-git source or modified so that they manage their own git directory.

+ go test ./...
--- FAIL: TestGitignoreChecksum (0.00s)
    --- FAIL: TestGitignoreChecksum/ignored_file_modified (0.00s)
        task_test.go:725: Result did not match the golden fixture. Diff is below:

            --- Expected
            +++ Actual
            @@ -1,2 +1,2 @@
            -task: Task "build" is up to date
            +task: [build] cp ./source.txt ./generated.txt


--- FAIL: TestGitignoreNegation (0.00s)
    --- FAIL: TestGitignoreNegation/ignored_file_modified (0.00s)
        task_test.go:741: Result did not match the golden fixture. Diff is below:

            --- Expected
            +++ Actual
            @@ -1,2 +1,3 @@
            -task: Task "build" is up to date
            +task: [build] echo "build executed"
            +build executed


--- FAIL: TestGitignoreNested (0.00s)
    --- FAIL: TestGitignoreNested/ignored_file_modified (0.00s)
        task_test.go:758: Result did not match the golden fixture. Diff is below:

            --- Expected
            +++ Actual
            @@ -1,2 +1,3 @@
            -task: Task "build" is up to date
            +task: [build] echo "build executed"
            +build executed


--- FAIL: TestGitignoreIncluded (0.00s)
    --- FAIL: TestGitignoreIncluded/ignored_file_modified (0.00s)
        task_test.go:773: Result did not match the golden fixture. Diff is below:

            --- Expected
            +++ Actual
            @@ -1,2 +1,3 @@
            -task: Task "included:build" is up to date
            +task: [included:build] echo "build executed"
            +build executed


FAIL
FAIL        github.com/go-task/task/v3      0.458s

Version

v3.52.0

Operating system

Linux (AerynOS)

Experiments Enabled

No response

Example Taskfile

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: releasingChanges related to the release process.

    Type

    Fields

    No fields configured for bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions