Use empty strings to clear issue types

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ea8faa5c-7f26-4e2d-bf9c-6f0b5f173e8c

Author: zwick

README.md

@@ -941,7 +941,7 @@ The following sets of tools are available:
   - `state`: New state (string, optional)
   - `state_reason`: Reason for the state change. Ignored unless state is changed. (string, optional)
   - `title`: Issue title (string, optional)
-  - `type`: Type of this issue. Use list_issue_types to get valid values. For updates, pass null to remove the current type. If the repository doesn't support issue types, omit this parameter. (, optional)
+  - `type`: Type of this issue. For updates, use an empty string to remove the current type. Only use if issue types are enabled for this repository. Use list_issue_types to get valid type values for this repository or its owner organization. If the repository doesn't support issue types, omit this parameter. (string, optional)
 
 - **list_issue_fields** - List issue fields
   - **Required OAuth Scopes (any of)**: `repo`, `read:org`

docs/feature-flags.md

@@ -71,7 +71,7 @@ runtime behavior (such as output formatting) won't appear here.
   - `state`: New state (string, optional)
   - `state_reason`: Reason for the state change. Ignored unless state is changed. (string, optional)
   - `title`: Issue title (string, optional)
-  - `type`: Type of this issue. Use list_issue_types to get valid values. For updates, pass null to remove the current type. If the repository doesn't support issue types, omit this parameter. (, optional)
+  - `type`: Type of this issue. For updates, use an empty string to remove the current type. Only use if issue types are enabled for this repository. Use list_issue_types to get valid type values for this repository or its owner organization. If the repository doesn't support issue types, omit this parameter. (string, optional)
 
 - **ui_get** - Get UI data
   - **Required OAuth Scopes (any of)**: `repo`, `read:org`
@@ -200,7 +200,7 @@ runtime behavior (such as output formatting) won't appear here.
   - `confidence`: How confident you are in this choice. Use 'HIGH' for clear signal or explicit user request, 'MEDIUM' for reasonable inference with some ambiguity, 'LOW' for best guess with limited signal. (string, optional)
   - `is_suggestion`: If true, this issue type change is sent to the API as a suggestion (suggest:true) rather than an applied value. Whether the type is applied or recorded as a proposal is determined by the API. (boolean, optional)
   - `issue_number`: The issue number to update (number, required)
-  - `issue_type`: The issue type to set, or null to remove the current type (, required)
+  - `issue_type`: The issue type to set, or an empty string to remove the current type (string, required)
   - `owner`: Repository owner (username or organization) (string, required)
   - `rationale`: One concise sentence explaining what specifically about the issue led you to choose this type. State the concrete signal (e.g. 'Reports a crash when saving' → bug, 'Asks for dark mode support' → feature). (string, optional)
   - `repo`: Repository name (string, required)

docs/insiders-features.md

@@ -65,7 +65,7 @@ The list below is generated from the Go source. It covers tool **inventory and s
   - `state`: New state (string, optional)
   - `state_reason`: Reason for the state change. Ignored unless state is changed. (string, optional)
   - `title`: Issue title (string, optional)
-  - `type`: Type of this issue. Use list_issue_types to get valid values. For updates, pass null to remove the current type. If the repository doesn't support issue types, omit this parameter. (, optional)
+  - `type`: Type of this issue. For updates, use an empty string to remove the current type. Only use if issue types are enabled for this repository. Use list_issue_types to get valid type values for this repository or its owner organization. If the repository doesn't support issue types, omit this parameter. (string, optional)
 
 - **ui_get** - Get UI data
   - **Required OAuth Scopes (any of)**: `repo`, `read:org`

pkg/github/__toolsnaps__/issue_write.snap

@@ -120,11 +120,8 @@
         "type": "string"
       },
       "type": {
-        "description": "Type of this issue. Use list_issue_types to get valid values. For updates, pass null to remove the current type. If the repository doesn't support issue types, omit this parameter.",
-        "type": [
-          "string",
-          "null"
-        ]
+        "description": "Type of this issue. For updates, use an empty string to remove the current type. Only use if issue types are enabled for this repository. Use list_issue_types to get valid type values for this repository or its owner organization. If the repository doesn't support issue types, omit this parameter.",
+        "type": "string"
       }
     },
     "required": [

pkg/github/__toolsnaps__/update_issue_type.snap

@@ -6,7 +6,7 @@
     "readOnlyHint": false,
     "title": "Update Issue Type"
   },
-  "description": "Set or remove the type of an existing issue. Pass null to remove the current type. When setting a value, include a confidence level (LOW, MEDIUM, or HIGH) reflecting how certain you are about the choice.",
+  "description": "Set or remove the type of an existing issue. Use an empty issue_type to remove the current type. When setting a value, include a confidence level (LOW, MEDIUM, or HIGH) reflecting how certain you are about the choice.",
   "inputSchema": {
     "properties": {
       "confidence": {
@@ -28,11 +28,8 @@
         "type": "number"
       },
       "issue_type": {
-        "description": "The issue type to set, or null to remove the current type",
-        "type": [
-          "string",
-          "null"
-        ]
+        "description": "The issue type to set, or an empty string to remove the current type",
+        "type": "string"
       },
       "owner": {
         "description": "Repository owner (username or organization)",

pkg/github/granular_tools_test.go

@@ -756,7 +756,7 @@ func TestGranularUpdateIssueMilestone(t *testing.T) {
 
 func TestGranularUpdateIssueType(t *testing.T) {
 	toolSchema := GranularUpdateIssueType(translations.NullTranslationHelper).Tool.InputSchema.(*jsonschema.Schema)
-	assert.ElementsMatch(t, []string{"string", "null"}, toolSchema.Properties["issue_type"].Types)
+	assert.Equal(t, "string", toolSchema.Properties["issue_type"].Type)
 
 	tests := []struct {
 		name        string
@@ -792,12 +792,12 @@ func TestGranularUpdateIssueType(t *testing.T) {
 			},
 		},
 		{
-			name: "remove type",
+			name: "remove type with empty string",
 			requestArgs: map[string]any{
 				"owner":        "owner",
 				"repo":         "repo",
 				"issue_number": float64(1),
-				"issue_type":   nil,
+				"issue_type":   "",
 			},
 			expectedReq: map[string]any{
 				"type": nil,

pkg/github/issues.go

@@ -2150,8 +2150,8 @@ Options are:
 						Description: "Milestone number",
 					},
 					"type": {
-						Types:       []string{"string", "null"},
-						Description: "Type of this issue. Use list_issue_types to get valid values. For updates, pass null to remove the current type. If the repository doesn't support issue types, omit this parameter.",
+						Type:        "string",
+						Description: "Type of this issue. For updates, use an empty string to remove the current type. Only use if issue types are enabled for this repository. Use list_issue_types to get valid type values for this repository or its owner organization. If the repository doesn't support issue types, omit this parameter.",
 					},
 					"state": {
 						Type:        "string",
@@ -2275,14 +2275,10 @@ Options are:
 			}
 
 			// Get optional type
-			issueTypeParam, issueTypeProvided, err := OptionalNullableStringParam(args, "type")
+			issueType, issueTypeProvided, err := OptionalParamOK[string](args, "type")
 			if err != nil {
 				return utils.NewToolResultError(err.Error()), nil, nil
 			}
-			issueType := ""
-			if issueTypeParam != nil {
-				issueType = *issueTypeParam
-			}
 
 			// Handle state, state_reason and duplicateOf parameters
 			state, err := OptionalParam[string](args, "state")
@@ -2340,7 +2336,7 @@ Options are:
 				result, err := UpdateIssue(ctx, client, gqlClient, owner, repo, issueNumber, title, body, assignees, labels, milestoneNum, issueType, issueFieldValues, fieldIDsToDelete, state, stateReason, duplicateOf, UpdateIssueOptions{
 					AssigneesProvided: assigneesProvided,
 					LabelsProvided:    labelsProvided,
-					ClearIssueType:    issueTypeProvided && issueTypeParam == nil,
+					ClearIssueType:    issueTypeProvided && issueType == "",
 				})
 				return result, nil, err
 			default:

pkg/github/issues_granular.go

@@ -685,7 +685,7 @@ func GranularUpdateIssueType(t translations.TranslationHelperFunc) inventory.Ser
 		ToolsetMetadataIssues,
 		mcp.Tool{
 			Name:        "update_issue_type",
-			Description: t("TOOL_UPDATE_ISSUE_TYPE_DESCRIPTION", "Set or remove the type of an existing issue. Pass null to remove the current type. When setting a value, include a confidence level (LOW, MEDIUM, or HIGH) reflecting how certain you are about the choice."),
+			Description: t("TOOL_UPDATE_ISSUE_TYPE_DESCRIPTION", "Set or remove the type of an existing issue. Use an empty issue_type to remove the current type. When setting a value, include a confidence level (LOW, MEDIUM, or HIGH) reflecting how certain you are about the choice."),
 			Annotations: &mcp.ToolAnnotations{
 				Title:           t("TOOL_UPDATE_ISSUE_TYPE_USER_TITLE", "Update Issue Type"),
 				ReadOnlyHint:    false,
@@ -709,8 +709,8 @@ func GranularUpdateIssueType(t translations.TranslationHelperFunc) inventory.Ser
 						Minimum:     jsonschema.Ptr(1.0),
 					},
 					"issue_type": {
-						Types:       []string{"string", "null"},
-						Description: "The issue type to set, or null to remove the current type",
+						Type:        "string",
+						Description: "The issue type to set, or an empty string to remove the current type",
 					},
 					"rationale": {
 						Type: "string",
@@ -746,7 +746,7 @@ func GranularUpdateIssueType(t translations.TranslationHelperFunc) inventory.Ser
 			if err != nil {
 				return utils.NewToolResultError(err.Error()), nil, nil
 			}
-			issueType, issueTypeProvided, err := OptionalNullableStringParam(args, "issue_type")
+			issueType, issueTypeProvided, err := OptionalParamOK[string](args, "issue_type")
 			if err != nil {
 				return utils.NewToolResultError(err.Error()), nil, nil
 			}
@@ -773,7 +773,7 @@ func GranularUpdateIssueType(t translations.TranslationHelperFunc) inventory.Ser
 			if err != nil {
 				return utils.NewToolResultError(err.Error()), nil, nil
 			}
-			if issueType == nil && (rationale != "" || confidence != "" || isSuggestion) {
+			if issueType == "" && (rationale != "" || confidence != "" || isSuggestion) {
 				return utils.NewToolResultError("rationale, confidence, and is_suggestion cannot be used when removing an issue type"), nil, nil
 			}
 
@@ -784,19 +784,19 @@ func GranularUpdateIssueType(t translations.TranslationHelperFunc) inventory.Ser
 
 			var body any
 			switch {
-			case issueType == nil:
+			case issueType == "":
 				body = map[string]any{"type": nil}
 			case rationale != "" || isSuggestion || confidence != "":
 				body = &issueTypeUpdateRequest{
 					Type: issueTypeWithIntent{
-						Value:      *issueType,
+						Value:      issueType,
 						Rationale:  rationale,
 						Confidence: confidence,
 						Suggest:    isSuggestion,
 					},
 				}
 			default:
-				body = &github.UpdateIssueRequest{Type: issueType}
+				body = &github.UpdateIssueRequest{Type: &issueType}
 			}
 
 			apiURL := fmt.Sprintf("repos/%s/%s/issues/%d", owner, repo, issueNumber)

pkg/github/issues_test.go

@@ -1434,7 +1434,7 @@ func Test_CreateIssue(t *testing.T) {
 	assert.Contains(t, tool.InputSchema.(*jsonschema.Schema).Properties, "labels")
 	assert.Contains(t, tool.InputSchema.(*jsonschema.Schema).Properties, "milestone")
 	assert.Contains(t, tool.InputSchema.(*jsonschema.Schema).Properties, "type")
-	assert.ElementsMatch(t, []string{"string", "null"}, tool.InputSchema.(*jsonschema.Schema).Properties["type"].Types)
+	assert.Equal(t, "string", tool.InputSchema.(*jsonschema.Schema).Properties["type"].Type)
 	assert.Contains(t, tool.InputSchema.(*jsonschema.Schema).Properties, "issue_fields")
 	assert.ElementsMatch(t, tool.InputSchema.(*jsonschema.Schema).Required, []string{"method", "owner", "repo"})
 
@@ -1513,6 +1513,36 @@ func Test_CreateIssue(t *testing.T) {
 				State:   github.Ptr("open"),
 			},
 		},
+		{
+			name: "empty issue type is omitted when creating",
+			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
+				PostReposIssuesByOwnerByRepo: expectRequestBody(t, map[string]any{
+					"title": "Issue without a type",
+					"body":  "",
+				}).andThen(
+					mockResponse(t, http.StatusCreated, &github.Issue{
+						Number:  github.Ptr(125),
+						Title:   github.Ptr("Issue without a type"),
+						HTMLURL: github.Ptr("https://github.com/owner/repo/issues/125"),
+						State:   github.Ptr("open"),
+					}),
+				),
+			}),
+			requestArgs: map[string]any{
+				"method": "create",
+				"owner":  "owner",
+				"repo":   "repo",
+				"title":  "Issue without a type",
+				"type":   "",
+			},
+			expectError: false,
+			expectedIssue: &github.Issue{
+				Number:  github.Ptr(125),
+				Title:   github.Ptr("Issue without a type"),
+				HTMLURL: github.Ptr("https://github.com/owner/repo/issues/125"),
+				State:   github.Ptr("open"),
+			},
+		},
 		{
 			name: "successful issue creation with issue fields reconciled by names",
 			mockedClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
@@ -1829,7 +1859,7 @@ func Test_issueWriteHasNonFormParams(t *testing.T) {
 		{name: "assignees present", args: map[string]any{"title": "t", "assignees": []any{"octocat"}}, want: false},
 		{name: "milestone present", args: map[string]any{"title": "t", "milestone": float64(2)}, want: false},
 		{name: "type present", args: map[string]any{"title": "t", "type": "Bug"}, want: false},
-		{name: "type clear present", args: map[string]any{"title": "t", "type": nil}, want: false},
+		{name: "type clear present", args: map[string]any{"title": "t", "type": ""}, want: false},
 		{name: "issue_fields present", args: map[string]any{"issue_fields": []any{map[string]any{"field_name": "Priority"}}}, want: false},
 		{name: "state present", args: map[string]any{"state": "closed"}, want: false},
 		{name: "state_reason present", args: map[string]any{"state_reason": "completed"}, want: false},
@@ -2965,7 +2995,7 @@ func Test_UpdateIssue(t *testing.T) {
 			expectedIssue: mockUpdatedIssue,
 		},
 		{
-			name: "partial update clears issue type",
+			name: "partial update clears issue type from empty string",
 			mockedRESTClient: MockHTTPClientWithHandlers(map[string]http.HandlerFunc{
 				PatchReposIssuesByOwnerByRepoByIssueNumber: expectRequestBody(t, map[string]any{
 					"type": nil,
@@ -2979,7 +3009,7 @@ func Test_UpdateIssue(t *testing.T) {
 				"owner":        "owner",
 				"repo":         "repo",
 				"issue_number": float64(123),
-				"type":         nil,
+				"type":         "",
 			},
 			expectError:   false,
 			expectedIssue: mockUpdatedIssue,

pkg/github/params.go

@@ -193,24 +193,6 @@ func OptionalParam[T any](args map[string]any, p string) (T, error) {
 	return args[p].(T), nil
 }
 
-// OptionalNullableStringParam returns a nullable string while preserving
-// whether the parameter was omitted.
-func OptionalNullableStringParam(args map[string]any, p string) (*string, bool, error) {
-	value, ok := args[p]
-	if !ok {
-		return nil, false, nil
-	}
-	if value == nil {
-		return nil, true, nil
-	}
-
-	stringValue, ok := value.(string)
-	if !ok {
-		return nil, true, fmt.Errorf("parameter %s is not of type string or null, is %T", p, value)
-	}
-	return &stringValue, true, nil
-}
-
 // OptionalIntParam is a helper function that can be used to fetch a requested parameter from the request.
 // It does the following checks:
 // 1. Checks if the parameter is present in the request, if not, it returns its zero-value