feat: Separate runtimes for taskbroker components#559
Closed
evanh wants to merge 3 commits into
Closed
Conversation
Create a separate tokio runtime for each of the consumer and gRPC server. The maintenance and upkeep threads will continue to use the default runtime. The number of threads allocated to each runtime is either specified by the TOKIO_WORKER_THREADS environment variable or defaults to the number of CPUs.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
markstory
reviewed
Feb 20, 2026
markstory
left a comment
markstory
left a comment
Member
There was a problem hiding this comment.
I'm interested to see how this impacts contention on sqlite, or if the connection can be shared across multiple runtimes.
Member
Author
I doubt it will have much impact on SQLite, we would still be locked at one process at a time. This change is meant more for the push taskbroker testing, so we can isolate the push threads from the other components. |
Member
Author
|
This is outdated now with the push changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a separate tokio runtime for each of the consumer and gRPC server. The maintenance and upkeep threads will continue to use the default runtime. The number of threads allocated to each runtime is specified by a config setting, or the TOKIO_WORKER_THREADS environment variable or defaults to the number of CPUs.