From 650469ef74284bec567f1ea125f705936b570059 Mon Sep 17 00:00:00 2001
From: Antonis Lilis <antonis.lilis@sentry.io>
Date: Wed, 22 Jul 2026 13:17:04 +0200
Subject: [PATCH] ci(e2e): remove CocoaPods sample build job

sentry-cocoa dropped CocoaPods (trunk) support after 9.19.1, so the
source-build fallback (SENTRY_USE_XCFRAMEWORK=0) can no longer resolve
newer versions. The dedicated CocoaPods regression job now fails on any
Cocoa bump past 9.19.1, so remove it and the now single-valued
sentry-consumption matrix dimension.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .github/workflows/sample-application.yml | 27 ++++++++----------------
 1 file changed, 9 insertions(+), 18 deletions(-)

diff --git a/.github/workflows/sample-application.yml b/.github/workflows/sample-application.yml
index 67fc1faba0..ffa621833d 100644
--- a/.github/workflows/sample-application.yml
+++ b/.github/workflows/sample-application.yml
@@ -43,7 +43,7 @@ jobs:
       caller_ref: ${{ github.ref }}
 
   build-ios:
-    name: Build ${{ matrix.rn-architecture }} ios ${{ matrix.build-type }} ${{ matrix.ios-use-frameworks }} ${{ matrix.sentry-consumption }}
+    name: Build ${{ matrix.rn-architecture }} ios ${{ matrix.build-type }} ${{ matrix.ios-use-frameworks }}
     runs-on: macos-26-xlarge
     needs: [diff_check, detect-changes]
     if: >-
@@ -60,16 +60,11 @@ jobs:
         rn-architecture: ["new"]
         ios-use-frameworks: ["no-frameworks"]
         build-type: ["dev", "production"]
-        sentry-consumption: ["xcframework"]
-        # `xcframework` is the default: RNSentry vendors a prebuilt
-        # `Sentry-Dynamic.xcframework` downloaded from sentry-cocoa's release.
-        # Keep a single CocoaPods job to catch regressions in the source-build
-        # fallback (`SENTRY_USE_XCFRAMEWORK=0`).
-        include:
-          - rn-architecture: "new"
-            ios-use-frameworks: "no-frameworks"
-            build-type: "production"
-            sentry-consumption: "cocoapods"
+        # RNSentry vendors a prebuilt `Sentry.xcframework` downloaded from
+        # sentry-cocoa's release. sentry-cocoa dropped CocoaPods (trunk)
+        # support after 9.19.1, so the source-build fallback
+        # (`SENTRY_USE_XCFRAMEWORK=0`) can no longer resolve newer versions
+        # and is not exercised here.
     steps:
       - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
 
@@ -105,7 +100,6 @@ jobs:
           [[ "${{ matrix.build-type }}" == "production" ]] && export ENABLE_PROD=1 || export ENABLE_PROD=0
           [[ "${{ matrix.rn-architecture }}" == "new" ]] && export ENABLE_NEW_ARCH=1 || export ENABLE_NEW_ARCH=0
           [[ "${{ matrix.ios-use-frameworks }}" == "dynamic-frameworks" ]] && export USE_FRAMEWORKS=dynamic
-          [[ "${{ matrix.sentry-consumption }}" == "cocoapods" ]] && export SENTRY_USE_XCFRAMEWORK=0
 
           ./scripts/pod-install.sh
 
@@ -123,10 +117,7 @@ jobs:
           ./scripts/build-ios.sh
 
       - name: Archive iOS App
-        # Only upload from the xcframework job (the default consumption path)
-        # to avoid duplicate artifact names when the CocoaPods regression job
-        # runs.
-        if: ${{ matrix.rn-architecture == 'new' && matrix.build-type == 'production' && matrix.ios-use-frameworks == 'no-frameworks' && matrix.sentry-consumption == 'xcframework' }}
+        if: ${{ matrix.rn-architecture == 'new' && matrix.build-type == 'production' && matrix.ios-use-frameworks == 'no-frameworks' }}
         working-directory: ${{ env.REACT_NATIVE_SAMPLE_PATH }}
         run: |
           zip -r \
@@ -134,7 +125,7 @@ jobs:
             sentryreactnativesample.app
 
       - name: Upload iOS APP
-        if: ${{ matrix.rn-architecture == 'new' && matrix.build-type == 'production' && matrix.ios-use-frameworks == 'no-frameworks' && matrix.sentry-consumption == 'xcframework' }}
+        if: ${{ matrix.rn-architecture == 'new' && matrix.build-type == 'production' && matrix.ios-use-frameworks == 'no-frameworks' }}
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
         with:
           name: sample-rn-${{ matrix.rn-architecture }}-${{ matrix.build-type }}-${{ matrix.ios-use-frameworks}}-ios
@@ -145,7 +136,7 @@ jobs:
         if: ${{ always() }}
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
         with:
-          name: build-sample-${{ matrix.rn-architecture }}-ios-${{ matrix.build-type }}-${{ matrix.ios-use-frameworks}}-${{ matrix.sentry-consumption }}-logs
+          name: build-sample-${{ matrix.rn-architecture }}-ios-${{ matrix.build-type }}-${{ matrix.ios-use-frameworks}}-logs
           path: ${{ env.REACT_NATIVE_SAMPLE_PATH }}/ios/*.log
 
   build-android: