From fc49c979bd951dd6e37ae44ba7f9848ad37f7884 Mon Sep 17 00:00:00 2001 From: Ilya Yakelzon Date: Fri, 21 Aug 2026 12:45:34 +0200 Subject: [PATCH 1/3] build: bump lampshade to fix session desync that hung TestRoundTrip MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit An ACK frame arriving for an already-closed stream left its 4-byte payload unconsumed in the session-frame parser, which then misread those zero bytes as a padding header and silently discarded every remaining frame coalesced in the same session frame — permanently stalling unrelated live streams. With AckOnFirst (which our Wrap sets) this is easy to hit under concurrency and caused the rare 10-minute TestRoundTrip timeouts in CI. Fixed upstream in getlantern/lampshade#53. Co-Authored-By: Claude Fable 5 --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index d73afed4..38f83d4b 100644 --- a/go.mod +++ b/go.mod @@ -23,7 +23,7 @@ require ( github.com/getlantern/idletiming v0.0.0-20200228204104-10036786eac5 github.com/getlantern/kcpwrapper v0.0.0-20230327091313-c12d7c17c6de github.com/getlantern/keyman v0.0.0-20230503155501-4e864ca2175b - github.com/getlantern/lampshade v0.0.0-20200303040944-fe53f13203e9 + github.com/getlantern/lampshade v0.0.0-20260821104346-0863c5c50ba1 github.com/getlantern/lantern-algeneva v0.0.0-20240418193310-610690afddbc github.com/getlantern/lantern-water v0.0.0-20241217184729-97b2bf6add4a github.com/getlantern/measured v0.0.0-20230919230611-3d9e3776a6cd diff --git a/go.sum b/go.sum index b20256f3..bfaf3504 100644 --- a/go.sum +++ b/go.sum @@ -281,8 +281,8 @@ github.com/getlantern/keepcurrent v0.0.0-20260616120552-f204338b01a3/go.mod h1:a github.com/getlantern/keyman v0.0.0-20180207174507-f55e7280e93a/go.mod h1:FMf0g72BHs14jVcD8i8ubEk4sMB6JdidBn67d44i3ws= github.com/getlantern/keyman v0.0.0-20230503155501-4e864ca2175b h1:iyEuk8ARQC9HfraqC4r3leBhU55R1TV7bAiyPYE54kA= github.com/getlantern/keyman v0.0.0-20230503155501-4e864ca2175b/go.mod h1:ZJ+yDaZkJ/JU9j7EQa3UUh6ouedrNDDLA5OiowS1Iuk= -github.com/getlantern/lampshade v0.0.0-20200303040944-fe53f13203e9 h1:n2t63QvweEs53Kpy7QbXv6JRSfXpDTTgPMT4cNTOt8g= -github.com/getlantern/lampshade v0.0.0-20200303040944-fe53f13203e9/go.mod h1:Zqiq4op+E689yjuJACMLURzE9XUGj48UDZP7h8aN+kk= +github.com/getlantern/lampshade v0.0.0-20260821104346-0863c5c50ba1 h1:bHG5ikpF2nHxfbwoGhPXV1W5mIaxZF3k8Wvjqc6BYS8= +github.com/getlantern/lampshade v0.0.0-20260821104346-0863c5c50ba1/go.mod h1:Zqiq4op+E689yjuJACMLURzE9XUGj48UDZP7h8aN+kk= github.com/getlantern/lantern-algeneva v0.0.0-20240418193310-610690afddbc h1:NlvxqmHvBr27TBzbxUsOFXtRtgW7FmoMkTTQhD6LXKU= github.com/getlantern/lantern-algeneva v0.0.0-20240418193310-610690afddbc/go.mod h1:bNnBc1YoooeKURbR6TMgNTuBA5ZjD28TSvZjbPUomVI= github.com/getlantern/lantern-water v0.0.0-20241217184729-97b2bf6add4a h1:3i8teo3y32raoP3g0crSwEVjeZvCxjoEIGVbtBhttIw= From 8161e1d66f5a0d6184e1498ee427c86a4abbc98f Mon Sep 17 00:00:00 2001 From: Ilya Yakelzon Date: Fri, 21 Aug 2026 12:55:30 +0200 Subject: [PATCH 2/3] build: re-pin lampshade to updated fix branch head Co-Authored-By: Claude Fable 5 --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index 38f83d4b..ee10fccf 100644 --- a/go.mod +++ b/go.mod @@ -23,7 +23,7 @@ require ( github.com/getlantern/idletiming v0.0.0-20200228204104-10036786eac5 github.com/getlantern/kcpwrapper v0.0.0-20230327091313-c12d7c17c6de github.com/getlantern/keyman v0.0.0-20230503155501-4e864ca2175b - github.com/getlantern/lampshade v0.0.0-20260821104346-0863c5c50ba1 + github.com/getlantern/lampshade v0.0.0-20260821105435-79296751c6d0 github.com/getlantern/lantern-algeneva v0.0.0-20240418193310-610690afddbc github.com/getlantern/lantern-water v0.0.0-20241217184729-97b2bf6add4a github.com/getlantern/measured v0.0.0-20230919230611-3d9e3776a6cd diff --git a/go.sum b/go.sum index bfaf3504..0891a16e 100644 --- a/go.sum +++ b/go.sum @@ -281,8 +281,8 @@ github.com/getlantern/keepcurrent v0.0.0-20260616120552-f204338b01a3/go.mod h1:a github.com/getlantern/keyman v0.0.0-20180207174507-f55e7280e93a/go.mod h1:FMf0g72BHs14jVcD8i8ubEk4sMB6JdidBn67d44i3ws= github.com/getlantern/keyman v0.0.0-20230503155501-4e864ca2175b h1:iyEuk8ARQC9HfraqC4r3leBhU55R1TV7bAiyPYE54kA= github.com/getlantern/keyman v0.0.0-20230503155501-4e864ca2175b/go.mod h1:ZJ+yDaZkJ/JU9j7EQa3UUh6ouedrNDDLA5OiowS1Iuk= -github.com/getlantern/lampshade v0.0.0-20260821104346-0863c5c50ba1 h1:bHG5ikpF2nHxfbwoGhPXV1W5mIaxZF3k8Wvjqc6BYS8= -github.com/getlantern/lampshade v0.0.0-20260821104346-0863c5c50ba1/go.mod h1:Zqiq4op+E689yjuJACMLURzE9XUGj48UDZP7h8aN+kk= +github.com/getlantern/lampshade v0.0.0-20260821105435-79296751c6d0 h1:iy5UU1fc1izoOd1OXz8VCk6OzBF7sD1v29XMEmnFBdg= +github.com/getlantern/lampshade v0.0.0-20260821105435-79296751c6d0/go.mod h1:Zqiq4op+E689yjuJACMLURzE9XUGj48UDZP7h8aN+kk= github.com/getlantern/lantern-algeneva v0.0.0-20240418193310-610690afddbc h1:NlvxqmHvBr27TBzbxUsOFXtRtgW7FmoMkTTQhD6LXKU= github.com/getlantern/lantern-algeneva v0.0.0-20240418193310-610690afddbc/go.mod h1:bNnBc1YoooeKURbR6TMgNTuBA5ZjD28TSvZjbPUomVI= github.com/getlantern/lantern-water v0.0.0-20241217184729-97b2bf6add4a h1:3i8teo3y32raoP3g0crSwEVjeZvCxjoEIGVbtBhttIw= From 3890bcfd091989174e080112ca1eaf5d0262fe00 Mon Sep 17 00:00:00 2001 From: Ilya Yakelzon Date: Fri, 21 Aug 2026 16:07:05 +0200 Subject: [PATCH 3/3] build: re-pin lampshade to merged master commit getlantern/lampshade#53 is merged; point at the merge commit on master instead of the PR branch head. Co-Authored-By: Claude Fable 5 --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index ee10fccf..94777d13 100644 --- a/go.mod +++ b/go.mod @@ -23,7 +23,7 @@ require ( github.com/getlantern/idletiming v0.0.0-20200228204104-10036786eac5 github.com/getlantern/kcpwrapper v0.0.0-20230327091313-c12d7c17c6de github.com/getlantern/keyman v0.0.0-20230503155501-4e864ca2175b - github.com/getlantern/lampshade v0.0.0-20260821105435-79296751c6d0 + github.com/getlantern/lampshade v0.0.0-20260821140109-7c74457479f7 github.com/getlantern/lantern-algeneva v0.0.0-20240418193310-610690afddbc github.com/getlantern/lantern-water v0.0.0-20241217184729-97b2bf6add4a github.com/getlantern/measured v0.0.0-20230919230611-3d9e3776a6cd diff --git a/go.sum b/go.sum index 0891a16e..2843071b 100644 --- a/go.sum +++ b/go.sum @@ -281,8 +281,8 @@ github.com/getlantern/keepcurrent v0.0.0-20260616120552-f204338b01a3/go.mod h1:a github.com/getlantern/keyman v0.0.0-20180207174507-f55e7280e93a/go.mod h1:FMf0g72BHs14jVcD8i8ubEk4sMB6JdidBn67d44i3ws= github.com/getlantern/keyman v0.0.0-20230503155501-4e864ca2175b h1:iyEuk8ARQC9HfraqC4r3leBhU55R1TV7bAiyPYE54kA= github.com/getlantern/keyman v0.0.0-20230503155501-4e864ca2175b/go.mod h1:ZJ+yDaZkJ/JU9j7EQa3UUh6ouedrNDDLA5OiowS1Iuk= -github.com/getlantern/lampshade v0.0.0-20260821105435-79296751c6d0 h1:iy5UU1fc1izoOd1OXz8VCk6OzBF7sD1v29XMEmnFBdg= -github.com/getlantern/lampshade v0.0.0-20260821105435-79296751c6d0/go.mod h1:Zqiq4op+E689yjuJACMLURzE9XUGj48UDZP7h8aN+kk= +github.com/getlantern/lampshade v0.0.0-20260821140109-7c74457479f7 h1:BA/09auzzo/60SMwoYEYxDL1hzLNVfbqAHnpbkIXfRI= +github.com/getlantern/lampshade v0.0.0-20260821140109-7c74457479f7/go.mod h1:Zqiq4op+E689yjuJACMLURzE9XUGj48UDZP7h8aN+kk= github.com/getlantern/lantern-algeneva v0.0.0-20240418193310-610690afddbc h1:NlvxqmHvBr27TBzbxUsOFXtRtgW7FmoMkTTQhD6LXKU= github.com/getlantern/lantern-algeneva v0.0.0-20240418193310-610690afddbc/go.mod h1:bNnBc1YoooeKURbR6TMgNTuBA5ZjD28TSvZjbPUomVI= github.com/getlantern/lantern-water v0.0.0-20241217184729-97b2bf6add4a h1:3i8teo3y32raoP3g0crSwEVjeZvCxjoEIGVbtBhttIw=