From 42edf3a2133ce1d43da2829cce620b20f1e36e04 Mon Sep 17 00:00:00 2001 From: Fiona Date: Mon, 24 Aug 2026 05:14:14 -0700 Subject: [PATCH] test: disable the string-building micro-benchmark The test asserts that buildString beats joinToString at the 90th percentile of measured wall-clock time. On a shared CI runner that comparison flips, and because unit tests gate publishing, it fails releases that are otherwise sound -- one such release failed today and passed on a rerun of the same commit. It measures a performance claim rather than correctness, so it should not hold a veto over publishing. Disable it and run it locally when the claim needs revisiting. --- .../utils/JointToStringVsStringBuilderPerformanceTest.kt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dd-sdk-android-core/src/test/kotlin/com/datadog/android/utils/JointToStringVsStringBuilderPerformanceTest.kt b/dd-sdk-android-core/src/test/kotlin/com/datadog/android/utils/JointToStringVsStringBuilderPerformanceTest.kt index 6f3b8acd40..30f97a6daf 100644 --- a/dd-sdk-android-core/src/test/kotlin/com/datadog/android/utils/JointToStringVsStringBuilderPerformanceTest.kt +++ b/dd-sdk-android-core/src/test/kotlin/com/datadog/android/utils/JointToStringVsStringBuilderPerformanceTest.kt @@ -9,6 +9,7 @@ import com.datadog.android.internal.utils.appendIfNotEmpty import fr.xgouchet.elmyr.Forge import fr.xgouchet.elmyr.junit5.ForgeExtension import org.assertj.core.api.Assertions.assertThat +import org.junit.jupiter.api.Disabled import org.junit.jupiter.api.Test import org.junit.jupiter.api.extension.ExtendWith import org.junit.jupiter.api.extension.Extensions @@ -20,6 +21,11 @@ import kotlin.system.measureNanoTime @Extensions( ExtendWith(ForgeExtension::class) ) +@Disabled( + "Wall-clock micro-benchmark rather than a correctness test: it compares two string-building " + + "approaches by measured time, so it flips on a shared CI runner and fails a release that is " + + "otherwise sound. Run it locally when the performance claim needs revisiting." +) internal class JointToStringVsStringBuilderPerformanceTest { @Test