From 81ac76f806b1b47331990df91704031729c7448d Mon Sep 17 00:00:00 2001 From: Sam Severance Date: Wed, 13 May 2026 16:14:36 -0400 Subject: [PATCH] Fix dead-code OR expression in permission-denied assertion `'permission-denied' || 'PERMISSION_DENIED'` always evaluates to the first string due to JS short-circuit; drop the unreachable alternative so the assertion matches only the actual error code. --- unit-test-security-rules-v9/test/utils.ts | 2 +- unit-test-security-rules/test/utils.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/unit-test-security-rules-v9/test/utils.ts b/unit-test-security-rules-v9/test/utils.ts index ede40edf..52f6c62d 100644 --- a/unit-test-security-rules-v9/test/utils.ts +++ b/unit-test-security-rules-v9/test/utils.ts @@ -45,7 +45,7 @@ export function getDatabaseCoverageMeta(databaseName: string, firebaseJsonPath: export async function expectFirestorePermissionDenied(promise: Promise) { const errorResult = await assertFails(promise); - expect(errorResult.code).toBe('permission-denied' || 'PERMISSION_DENIED'); + expect(errorResult.code).toBe('permission-denied'); } export async function expectDatabasePermissionDenied(promise: Promise) { diff --git a/unit-test-security-rules/test/utils.ts b/unit-test-security-rules/test/utils.ts index e6ca6e4b..f635e0bc 100644 --- a/unit-test-security-rules/test/utils.ts +++ b/unit-test-security-rules/test/utils.ts @@ -45,7 +45,7 @@ export function getDatabaseCoverageMeta(databaseName: string, firebaseJsonPath: export async function expectFirestorePermissionDenied(promise: Promise) { const errorResult = await assertFails(promise); - expect(errorResult.code).toBe('permission-denied' || 'PERMISSION_DENIED'); + expect(errorResult.code).toBe('permission-denied'); } export async function expectDatabasePermissionDenied(promise: Promise) {