feat(fdc): Add TODO for partial errors and include response payload in error message

Added a TODO comment referencing b/406281627 for partial errors support in ExecuteGraphqlResponse and _parse_graphql_response. Updated _parse_graphql_response to include the raw response payload in the InternalError message string for improved debug visibility.

Author: mk2023

firebase_admin/dataconnect.py

@@ -23,7 +23,6 @@
 import typing
 from typing import Any, Dict, Generic, Optional, Type, TypeVar, Union
 
-
 import requests
 
 import firebase_admin
@@ -195,11 +194,18 @@ class GraphqlOptions(Generic[_Variables]):
     impersonate: Optional[Union[Impersonation, Dict[str, Any]]] = None
 
 
+# TODO(b/406281627): Add support for partial errors.
 @dataclass
 class ExecuteGraphqlResponse(Generic[_Data]):
+    """Represents the response from a DataConnect GraphQL execution.
+
+    Attributes:
+        data: The raw JSON dictionary returned by the GraphQL execution.
+    """
     data: _Data
 
 
+
 def _get_emulator_host() -> Optional[str]:
     return _utils.get_emulator_host("DATA_CONNECT_EMULATOR_HOST")
 
@@ -410,7 +416,8 @@ def _parse_graphql_response(
         """Parses a raw GraphQL response payload into ExecuteGraphqlResponse."""
         if not isinstance(resp_dict, dict):
             raise exceptions.InternalError(
-                message="Response payload is not a valid JSON dictionary."
+                message=f"Response payload is not a valid JSON dictionary: {resp_dict}"
             )
 
+        # TODO(b/406281627): Add support for partial errors.
         return ExecuteGraphqlResponse(data=resp_dict.get("data"))

tests/test_data_connect.py

@@ -880,4 +880,6 @@ def test_parse_graphql_response_non_dict_error(self):
             self.api_client._parse_graphql_response("not-a-dict")
 
         assert excinfo.value.code == exceptions.INTERNAL
-        assert str(excinfo.value) == "Response payload is not a valid JSON dictionary."
+        assert str(excinfo.value) == (
+            "Response payload is not a valid JSON dictionary: not-a-dict"
+        )