You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The pending 0.5.0 release requires an adapter that does not exist on npm yet. If 0.5.0 ships, or is tested, against the current published adapter, magic-link login returns 404.
The adapter change that serves the POST route is fix(express)!: ... drop GET state changes (seamless-auth-server PR fix(client)!: request OTP generation over POST #103), which is merged but not published.
npm's latest @seamless-auth/express is 0.8.0, which still serves GET /magic-link and has no POST route.
So against any currently installable adapter, POST /auth/magic-link 404s and magic-link sign-in is broken.
Impact
Blocks the 0.5.0 release: publishing the SDK before the adapter leaves every adopter's magic-link flow broken until they can install an adapter that does not exist yet.
Blocks end-to-end testing: a local or CI run against 0.8.0 will show magic-link failing for a reason unrelated to the code under test.
For local testing before the adapter is published, run against the adapter's #103 branch rather than 0.8.0.
Broader point
This is the second SDK change in this cycle to hard-depend on a specific adapter version (the WebAuthn casing coupling was the first). It is worth documenting the SDK-to-adapter version compatibility somewhere adopters can see it, for example a compatibility table in the README or RELEASES.md, so a version skew surfaces as a documented requirement rather than a 404.
Summary
The pending 0.5.0 release requires an adapter that does not exist on npm yet. If 0.5.0 ships, or is tested, against the current published adapter, magic-link login returns 404.
The mismatch
maincarriesfix(client)!: request magic links over POST(02c99f3, closes requestMagicLink must use POST after the express adapter drops GET /magic-link #93).requestMagicLink()now callsPOST /auth/magic-link, and the changeset states it requires@seamless-auth/express0.9.0 or later.fix(express)!: ... drop GET state changes(seamless-auth-server PR fix(client)!: request OTP generation over POST #103), which is merged but not published.@seamless-auth/expressis 0.8.0, which still servesGET /magic-linkand has no POST route.So against any currently installable adapter,
POST /auth/magic-link404s and magic-link sign-in is broken.Impact
What needs to happen
@seamless-auth/express0.9.0 (or whatever version includes PR fix(client)!: request OTP generation over POST #103) first, or at minimum in the same release window.@seamless-auth/react0.5.0.#103branch rather than 0.8.0.Broader point
This is the second SDK change in this cycle to hard-depend on a specific adapter version (the WebAuthn casing coupling was the first). It is worth documenting the SDK-to-adapter version compatibility somewhere adopters can see it, for example a compatibility table in the README or RELEASES.md, so a version skew surfaces as a documented requirement rather than a 404.
Related